From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/i915: fix possible RPM ref leaking
 during RPS disabling
Date: Tue, 13 May 2014 15:54:40 +0200
Message-ID: <20140513135440.GI3908@phenom.ffwll.local>
References: <1399908905-3025-1-git-send-email-imre.deak@intel.com>
 <20140512175157.GC25056@phenom.ffwll.local>
 <1399988770.5451.3.camel@intelbox>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
 by gabe.freedesktop.org (Postfix) with ESMTP id 842B06E656
 for <intel-gfx@lists.freedesktop.org>; Tue, 13 May 2014 06:54:44 -0700 (PDT)
Received: by mail-wg0-f45.google.com with SMTP id m15so411437wgh.4
 for <intel-gfx@lists.freedesktop.org>; Tue, 13 May 2014 06:54:43 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1399988770.5451.3.camel@intelbox>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, May 13, 2014 at 04:46:10PM +0300, Imre Deak wrote:
> On Mon, 2014-05-12 at 19:51 +0200, Daniel Vetter wrote:
> > On Mon, May 12, 2014 at 06:35:04PM +0300, Imre Deak wrote:
> > > In
> > > 
> > > commit c6df39b5ea6342323a42edfbeeca0a28c643d7ae
> > > Author: Imre Deak <imre.deak@intel.com>
> > > Date:   Mon Apr 14 20:24:29 2014 +0300
> > > 
> > >     drm/i915: get a runtime PM ref for the deferred GT powersave enabling
> > > 
> > > I added an RPM get-ref when enabling RPS from a deferred work, but forgot
> > > to add the corresponding put-ref when canceling the work. This may leave
> > > RPM disabled.
> > > 
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > 
> > Could we intentionally hit this by e.g. racing a suspend/resume against
> > runtime pm? E.g.
> > 1. disable all outputs, make sure we've entered runtime pm
> > 2. set runtime autosuspend delay to 0
> > 3. suspend/resume
> > 4. autosuspend (hopefully, my understanding is a bit unclear)
> > 
> > ->Boom
> > 
> > Would look nice as an igt subtest if it works ;-)
> 
> Yep, works consistently as expected both before and after the fix. I
> pushed the new subtest, please add here:
> Testcase: igt/pm_pc8/system-suspend

Now I'm confused: I expected this to blow up without your fix here, and
not work with or without it?! Please unconfuse ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch