From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 09/10] i915: add DP 1.2 MST support (v0.3)
Date: Wed, 14 May 2014 10:23:55 +0200
Message-ID: <20140514082355.GC8790@phenom.ffwll.local>
References: <1399877207-15868-1-git-send-email-airlied@gmail.com>
 <1399877207-15868-10-git-send-email-airlied@gmail.com>
 <CANq1E4S2gNm6D10ZQLNnOpj==VfwrwQR0hHHFzDDZznARsBAEA@mail.gmail.com>
 <CAPM=9tyfX6qeiCNHXgsOxZVLsVMykmN-E9fC4HE6W5wNbz42Cw@mail.gmail.com>
 <CANq1E4RUqrgGjJb9ebGWMei6xQrwm7Q_-iZgVrfR3MtSWUPtLg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f46.google.com (mail-ee0-f46.google.com [74.125.83.46])
 by gabe.freedesktop.org (Postfix) with ESMTP id 6F3156EC18
 for <intel-gfx@lists.freedesktop.org>; Wed, 14 May 2014 01:24:00 -0700 (PDT)
Received: by mail-ee0-f46.google.com with SMTP id t10so1071604eei.33
 for <intel-gfx@lists.freedesktop.org>; Wed, 14 May 2014 01:23:59 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CANq1E4RUqrgGjJb9ebGWMei6xQrwm7Q_-iZgVrfR3MtSWUPtLg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, May 14, 2014 at 08:05:11AM +0200, David Herrmann wrote:
> Hi
> 
> On Wed, May 14, 2014 at 2:03 AM, Dave Airlie <airlied@gmail.com> wrote:
> > Since any objects you get with find are only valid under mode_config.mutex,
> > yes some drivers mess this up, but they should be fixed.
> 
> Didn't know that we have such a rule. Then it's fine, of course. The
> page-flip code is what worried me, but drivers ought to cancel that
> when destroying connectors, anyway.

i915 cancels/stalls for any pageflips when we switch off the crtc, so I
think we should be fine.

And the above rule is for all modeset objects except framebuffers, since
those are separately protected with refcounting and you don't even need
the big mode_config mutex to do the idr lookup.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch