From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915: use dev_priv directly in i915_driver_unload
Date: Wed, 14 May 2014 13:12:52 +0200 [thread overview]
Message-ID: <20140514111252.GE8790@phenom.ffwll.local> (raw)
In-Reply-To: <20140514100403.GA1486@strange.amr.corp.intel.com>
On Wed, May 14, 2014 at 11:04:03AM +0100, Damien Lespiau wrote:
> On Tue, May 13, 2014 at 10:21:59PM +0200, Daniel Vetter wrote:
> > Noticed while playing with coccinelle.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Queued for -next, thanks for the review.
-Daniel
>
> > ---
> > drivers/gpu/drm/i915/i915_dma.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> > index d02c8de4bd6c..46f1decab76f 100644
> > --- a/drivers/gpu/drm/i915/i915_dma.c
> > +++ b/drivers/gpu/drm/i915/i915_dma.c
> > @@ -1867,7 +1867,7 @@ int i915_driver_unload(struct drm_device *dev)
> > kmem_cache_destroy(dev_priv->slab);
> >
> > pci_dev_put(dev_priv->bridge_dev);
> > - kfree(dev->dev_private);
> > + kfree(dev_priv);
> >
> > return 0;
> > }
> > --
> > 1.9.2
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-05-14 11:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 20:21 [PATCH 1/2] drm/i915: use dev_priv directly in i915_driver_unload Daniel Vetter
2014-05-13 20:22 ` [PATCH 2/2] drm/i915: s/dev->dev_private/to_i915(dev)/ Daniel Vetter
2014-05-13 21:56 ` Jesse Barnes
2014-05-13 22:24 ` Jesse Barnes
2014-05-14 8:51 ` Jani Nikula
2014-05-14 10:04 ` [PATCH 1/2] drm/i915: use dev_priv directly in i915_driver_unload Damien Lespiau
2014-05-14 11:12 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514111252.GE8790@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox