From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 06/50] drm/i915: s/intel_ring_buffer/intel_engine Date: Wed, 14 May 2014 14:26:20 +0100 Message-ID: <20140514132620.GA6515@strange.amr.corp.intel.com> References: <1399637360-4277-1-git-send-email-oscar.mateo@intel.com> <1399637360-4277-7-git-send-email-oscar.mateo@intel.com> <20140513132827.GF3908@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id A4A756E4D2 for ; Wed, 14 May 2014 06:26:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140513132827.GF3908@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 13, 2014 at 03:28:27PM +0200, Daniel Vetter wrote: > On Fri, May 09, 2014 at 01:08:36PM +0100, oscar.mateo@intel.com wrote: > > From: Oscar Mateo > > > > In the upcoming patches, we plan to break the correlation between > > engines (a.k.a. rings) and ringbuffers, so it makes sense to > > refactor the code and make the change obvious. > > > > No functional changes. > > > > Signed-off-by: Oscar Mateo > > If we rename stuff I'd vote for something close to Bspec language, like > CS. So maybe intel_cs_engine? Also, can we have such patches (and the like of "drm/i915: for_each_ring") pushed early when everyone is happy with them, they cause constant rebasing pain. Thanks, -- Damien