From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] lib/igt_aux: Extract runtime pm helpers from pm_pc8
Date: Wed, 14 May 2014 20:34:03 +0200 [thread overview]
Message-ID: <20140514183403.GK8790@phenom.ffwll.local> (raw)
In-Reply-To: <20140514175027.GA14930@strange.amr.corp.intel.com>
On Wed, May 14, 2014 at 06:50:27PM +0100, Damien Lespiau wrote:
> On Wed, May 14, 2014 at 06:00:46PM +0200, Daniel Vetter wrote:
> > I want to use them elsewhere ...
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > lib/igt_aux.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > lib/igt_aux.h | 11 ++++++
> > tests/pm_pc8.c | 96 ++----------------------------------------------
> > 3 files changed, 128 insertions(+), 93 deletions(-)
>
> Just a small thing, let's not abuse _aux.c to put random stuff. How about
> adding a new _pm.c?
Well it's just three functions, the suspend helper is also already in
there and igt_aux is fairly small. We can split once it's too big.
igt_aux is very much just the bin for everything that doesn't fit anywhere
else ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-14 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 16:00 [PATCH 1/2] lib/igt_aux: Extract runtime pm helpers from pm_pc8 Daniel Vetter
2014-05-14 16:00 ` [PATCH 2/2] tests/kms_flip: nasty power management tests Daniel Vetter
2014-05-14 17:50 ` [PATCH 1/2] lib/igt_aux: Extract runtime pm helpers from pm_pc8 Damien Lespiau
2014-05-14 18:34 ` Daniel Vetter [this message]
2014-05-14 18:42 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514183403.GK8790@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox