From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 1/2] lib/igt_aux: Extract runtime pm helpers
 from pm_pc8
Date: Wed, 14 May 2014 19:42:00 +0100
Message-ID: <20140514184200.GA17336@strange.config>
References: <1400083247-18900-1-git-send-email-daniel.vetter@ffwll.ch>
 <20140514175027.GA14930@strange.amr.corp.intel.com>
 <20140514183403.GK8790@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 51FA66E668
 for <intel-gfx@lists.freedesktop.org>; Wed, 14 May 2014 11:42:03 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140514183403.GK8790@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, May 14, 2014 at 08:34:03PM +0200, Daniel Vetter wrote:
> On Wed, May 14, 2014 at 06:50:27PM +0100, Damien Lespiau wrote:
> > On Wed, May 14, 2014 at 06:00:46PM +0200, Daniel Vetter wrote:
> > > I want to use them elsewhere ...
> > > 
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > ---
> > >  lib/igt_aux.c  | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  lib/igt_aux.h  |  11 ++++++
> > >  tests/pm_pc8.c |  96 ++----------------------------------------------
> > >  3 files changed, 128 insertions(+), 93 deletions(-)
> > 
> > Just a small thing, let's not abuse _aux.c to put random stuff. How about
> > adding a new _pm.c?
> 
> Well it's just three functions, the suspend helper is also already in
> there and igt_aux is fairly small. We can split once it's too big.
> 
> igt_aux is very much just the bin for everything that doesn't fit anywhere
> else ;-)

Yeah, I can't see a kitchen-sink file going wrong, that has never
happened before :)

-- 
Damien