From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 3/4] drm/i915: MIPI PPS delays added Date: Thu, 15 May 2014 16:06:56 +0100 Message-ID: <20140515150656.GH27103@strange.amr.corp.intel.com> References: <1397454507-10273-1-git-send-email-shobhit.kumar@intel.com> <1397454507-10273-4-git-send-email-shobhit.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id DF8776EE85 for ; Thu, 15 May 2014 08:08:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1397454507-10273-4-git-send-email-shobhit.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shobhit Kumar Cc: Jani Nikula , Daniel Vetter , intel-gfx , arjan.van.de.ven@intel.com List-Id: intel-gfx@lists.freedesktop.org On Mon, Apr 14, 2014 at 11:18:26AM +0530, Shobhit Kumar wrote: > Added as generic parameters which will be initialized in the panel > driver and are specific to panels. > > Backlight delays have also kept as placeholders and will be used used > once we have MIPI backlight enabling support > > Signed-off-by: Shobhit Kumar Just a small note on patch ordering, You're using values that no code initializes yet, doesn't matter at all this time. Reviewed-by: Damien Lespiau -- Damien