Re: FW: [PATCH v8 3/9] drm/i915: Make sprite updates atomic

Arun Murthy
2014-05-19T11:08:31Z

On Mon, May 19, 2014 at 4:19 PM, Ville Syrjälä
<ville.syrjala@linux.intel.com> wrote:
> On Mon, May 19, 2014 at 04:08:09PM +0530, Arun Murthy wrote:
>> > Add a mechanism by which we can evade the leading edge of vblank. This
>> > guarantees that no two sprite register writes will straddle on either
>> > side of the vblank start, and that means all the writes will be latched
>> > together in one atomic operation.
>>
>>
>> Here only one sprite update followed by the primary enable/disable can be
>> achieved atomically. But I feel update of all planes are to be considered, i.e
>> update of planes per pipe basis to achieve atomicity.
>
> That's the final goal. This patch introduces the mechanism by which
> we can eventually implement the full atomic update.
>
Instead of tweaking with the existing functions pointers or IOCTL's can adding a
new function pointer in drm_crtc_funcs with element set_display.
This function in turn can set plane, do a page flip and also set few parameters
per pipe basis. Thereby achieving atomicity.
Can this approach work better?

Thanks and Regards,
Arun R Murthy
------------------