Re: [PATCH 3/4] drm/i915: enable VT switchless resume v3

Jesse Barnes
2013-04-03T15:13:27Z

On Wed, 3 Apr 2013 11:54:23 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Wed, Apr 03, 2013 at 11:15:40AM +0200, Daniel Vetter wrote:
> > On Tue, Mar 26, 2013 at 09:25:45AM -0700, Jesse Barnes wrote:
> > > With the other bits in place, we can do this safely.
> > >
> > > v2: disable backlight on suspend to prevent premature enablement on resume
> > > v3: disable CRTCs on suspend to allow RTD3 (Kristen)
> > >
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >
> > Something seems to be race with this, occasionally when resuming my vt is
> > on the X session (at least nothing happens when I try to switch to it),
> > the cursor is enabled, but I see the kernel console window.
> >
> > Doing a vt switch to a non-X console and back to X fixes things. I haven't
> > looked exactly where we could race ...
>
> This might be a DRM_MASTER race, if X fails to gain DRM_MASTER its
> takeover is postponed indefinitely. Any clues in Xorg.0.log?

Yeah, David said he saw this even w/o the VT switch patches. I've seen
this bug too, maybe the lack of a VT switch makes the race a little
more likely?

--
Jesse Barnes, Intel Open Source Technology Center