From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Sanitize cursors on driver load
Date: Fri, 16 May 2014 18:53:52 +0200 [thread overview]
Message-ID: <20140516165352.GU8790@phenom.ffwll.local> (raw)
In-Reply-To: <1400258219-19420-1-git-send-email-chris@chris-wilson.co.uk>
On Fri, May 16, 2014 at 05:36:59PM +0100, Chris Wilson wrote:
> Extremely unlikely to ever be required, but BIOSes do like to attack in
> unexpected ways.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a943ea7..5583e9b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11817,6 +11817,8 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc)
> /* Adjust the state of the output pipe according to whether we
> * have active connectors/encoders. */
> intel_crtc_update_dpms(&crtc->base);
> + intel_crtc_update_cursor(crtc,
> + intel_crtc->active && intel_crtc->cursor_bo);
Should we do this for sprite planes, too? That way it would be nice fodder
for Matt to clean up later on ;-)
-Daniel
>
> if (crtc->active != crtc->base.enabled) {
> struct intel_encoder *encoder;
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-16 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 16:36 [PATCH] drm/i915: Sanitize cursors on driver load Chris Wilson
2014-05-16 16:53 ` Daniel Vetter [this message]
2014-05-16 17:02 ` Chris Wilson
2014-05-16 17:22 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516165352.GU8790@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox