From: Daniel Vetter <daniel@ffwll.ch>
To: Vandana Kannan <vandana.kannan@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2
Date: Mon, 19 May 2014 13:45:37 +0200 [thread overview]
Message-ID: <20140519114537.GJ8790@phenom.ffwll.local> (raw)
In-Reply-To: <5379EB46.9010302@intel.com>
On Mon, May 19, 2014 at 05:00:14PM +0530, Vandana Kannan wrote:
> Please let me know your inputs on this..
> Given that making changes to avoid DRRS related checks in
> pipe_config_compare affects the overall design and future
> implementations related to RR switching, I think that using a quirk for
> downclock_mode to compare dp_m_n and dp_m2_n2 based on the RR in use,
>
> if (!low RR)
> compare dp_m_n
> else
> compare dp_m2_n2
>
> would avoid unrelated DRRS checks and make sure extension of DRRS
> implementation would be possible.
> Only thing would be that both dp_m_n and dp_m2_n2 cant be compared always..
Well my idea was for bdw we'd check that
hw.dp_m_n == sw.dp_m_n || hw.dp_m_n == sw.dp_m2_n2
without any checks using software state to figure out whether we're in low
RR mode or not. That way the pipe config checker only depends upon the 2
pipe configs, which is a nice proper for it to have.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-19 11:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 11:31 [PATCH] drm/i915: Adding debug code for dp_m2_n2 in crtc_config Vandana Kannan
2014-04-22 19:15 ` Daniel Vetter
2014-05-05 8:19 ` [PATCH v2] drm/i915: State readout and cross-checking for dp_m2_n2 Vandana Kannan
2014-05-12 10:27 ` Ville Syrjälä
2014-05-12 17:56 ` Daniel Vetter
2014-05-13 8:26 ` Vandana Kannan
2014-05-13 8:58 ` Daniel Vetter
2014-05-13 9:40 ` Vandana Kannan
2014-05-15 9:18 ` Vandana Kannan
2014-05-15 9:31 ` Ville Syrjälä
2014-05-15 9:55 ` Vandana Kannan
2014-05-19 11:30 ` Vandana Kannan
2014-05-19 11:45 ` Daniel Vetter [this message]
2014-05-19 12:30 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519114537.GJ8790@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vandana.kannan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox