From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/sysfs: expose the "force" connector
	attribute
Date: Mon, 19 May 2014 16:53:45 +0200
Message-ID: <20140519145345.GP8790@phenom.ffwll.local>
References: <1400506620-12509-1-git-send-email-thomas.wood@intel.com>
 <CANq1E4RXq4+T+aYuGiRqd83vC25ui-yXVmtKkfh3FbZEZBkrQg@mail.gmail.com>
 <CANkqdn285BFvV5iPH6aWKSW+1VAWy6YTty-4zmuUE1_w-Jic=Q@mail.gmail.com>
 <CANq1E4TKWJD3-FO6qK_=ioFtdPQPcEBGCO0Fh9c3V+cLq3_+0Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44])
 by gabe.freedesktop.org (Postfix) with ESMTP id 96FC66E520
 for <intel-gfx@lists.freedesktop.org>; Mon, 19 May 2014 07:53:50 -0700 (PDT)
Received: by mail-ee0-f44.google.com with SMTP id c41so3662322eek.17
 for <intel-gfx@lists.freedesktop.org>; Mon, 19 May 2014 07:53:49 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CANq1E4TKWJD3-FO6qK_=ioFtdPQPcEBGCO0Fh9c3V+cLq3_+0Q@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, May 19, 2014 at 04:44:15PM +0200, David Herrmann wrote:
> Hi
> 
> On Mon, May 19, 2014 at 4:41 PM, Thomas Wood <thomas.wood@intel.com> wrote:
> > On 19 May 2014 15:13, David Herrmann <dh.herrmann@gmail.com> wrote:
> >> Hi
> >>
> >> On Mon, May 19, 2014 at 3:37 PM, Thomas Wood <thomas.wood@intel.com> wrote:
> >>> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
> >>
> >> The commit-msg lacks any discussion why this change is done. What is
> >> the reason to do that? Isn't the kernel-command-line enough? Why is
> >> this a regular feature instead of a debugfs attribute?
> >
> >
> > It was intended as a debug/testing feature to allow tests in
> > intel-gpu-tools to enable or disable connectors:
> >
> > http://lists.freedesktop.org/archives/intel-gfx/2014-May/045556.html
> >
> >
> > I'll update the commit message for the next version of the patch.
> 
> Thanks! But please make it a debugfs feature, if possible. We
> shouldn't expose interfaces in sysfs that aren't part of the core API.
> Note that this might require you to encode the connector-name in the
> debugfs-attribute-name.

Imo having the read and write side in completely different parts doesn't
make a lot of sense. Hence I think doing this in sysfs is ok. Also users
might want to frob this for testing, and usually debugfs is a bit further
away on most systems.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch