From: Matt Roper <matthew.d.roper@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 1/4] drm: Support legacy cursor ioctls via universal planes when possible (v2)
Date: Mon, 19 May 2014 15:25:45 -0700 [thread overview]
Message-ID: <20140519222545.GE31484@intel.com> (raw)
In-Reply-To: <CAKMK7uFgD6LiXi3vEM011uSEnU007M5JiPf=gYtRK=PLrRtORA@mail.gmail.com>
On Sat, May 17, 2014 at 12:43:04AM +0200, Daniel Vetter wrote:
> On Sat, May 17, 2014 at 12:38 AM, Matt Roper <matthew.d.roper@intel.com> wrote:
> > + if (ret) {
> > + if (req->flags & DRM_MODE_CURSOR_BO)
> > + drm_mode_rmfb(dev, &fb->base.id, file_priv);
> > + return ret;
> > + }
>
> With the new refcount logic an unconditional
> drm_framebuffer_unreference should be here instead of this. I think,
> but please double-check since it's late here ;-)
> -Daniel
Actually, I'm not sure if we want the unreference at all.
setplane_internal() unrefs fb on failure (and old_fb on success), so I
think that's already taken care of.
Matt
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
next prev parent reply other threads:[~2014-05-19 22:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 1:17 [RFC 0/4] Cursor support with universal planes Matt Roper
2014-05-16 1:17 ` [RFC 1/4] drm: Support legacy cursor ioctls via universal planes when possible Matt Roper
2014-05-16 16:00 ` [Intel-gfx] " Daniel Vetter
2014-05-16 22:38 ` [PATCH 1/4] drm: Support legacy cursor ioctls via universal planes when possible (v2) Matt Roper
2014-05-16 22:43 ` Daniel Vetter
2014-05-19 7:28 ` Daniel Vetter
2014-05-19 22:25 ` Matt Roper [this message]
2014-05-20 7:24 ` Daniel Vetter
2014-05-16 1:17 ` [RFC 2/4] drm: Allow drivers to register cursor planes with crtc Matt Roper
2014-05-16 16:01 ` [Intel-gfx] " Daniel Vetter
2014-05-16 1:17 ` [RFC 3/4] drm/i915: Add intel_crtc_cursor_set_obj() to set cursor buffer Matt Roper
2014-05-16 16:08 ` Daniel Vetter
2014-05-16 22:57 ` [PATCH 3/4] drm/i915: Add intel_crtc_cursor_set_obj() to set cursor buffer (v2) Matt Roper
2014-05-16 1:17 ` [RFC 4/4] drm/i915: Switch to unified plane cursor handling Matt Roper
2014-05-16 10:39 ` Chris Wilson
2014-05-16 16:24 ` Daniel Vetter
2014-05-16 9:19 ` [RFC 0/4] Cursor support with universal planes Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519222545.GE31484@intel.com \
--to=matthew.d.roper@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox