From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/4] drm: Support legacy cursor ioctls via
 universal planes when possible (v2)
Date: Mon, 19 May 2014 15:25:45 -0700
Message-ID: <20140519222545.GE31484@intel.com>
References: <1400203049-21385-2-git-send-email-matthew.d.roper@intel.com>
 <1400279896-26112-1-git-send-email-matthew.d.roper@intel.com>
 <CAKMK7uFgD6LiXi3vEM011uSEnU007M5JiPf=gYtRK=PLrRtORA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <CAKMK7uFgD6LiXi3vEM011uSEnU007M5JiPf=gYtRK=PLrRtORA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, May 17, 2014 at 12:43:04AM +0200, Daniel Vetter wrote:
> On Sat, May 17, 2014 at 12:38 AM, Matt Roper <matthew.d.roper@intel.com> wrote:
> > +       if (ret) {
> > +               if (req->flags & DRM_MODE_CURSOR_BO)
> > +                       drm_mode_rmfb(dev, &fb->base.id, file_priv);
> > +               return ret;
> > +       }
> 
> With the new refcount logic an unconditional
> drm_framebuffer_unreference should be here instead of this. I think,
> but please double-check since it's late here ;-)
> -Daniel

Actually, I'm not sure if we want the unreference at all.
setplane_internal() unrefs fb on failure (and old_fb on success), so I
think that's already taken care of.


Matt

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795