From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 23/66] drm/i915/dsi: Remove ->mode_set
 callback
Date: Tue, 20 May 2014 14:07:46 +0200
Message-ID: <20140520120746.GR8790@phenom.ffwll.local>
References: <1398376542-27825-1-git-send-email-daniel.vetter@ffwll.ch>
 <1398376542-27825-24-git-send-email-daniel.vetter@ffwll.ch>
 <537B43B2.50208@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f52.google.com (mail-ee0-f52.google.com [74.125.83.52])
 by gabe.freedesktop.org (Postfix) with ESMTP id 9BCF36E8CC
 for <intel-gfx@lists.freedesktop.org>; Tue, 20 May 2014 05:07:50 -0700 (PDT)
Received: by mail-ee0-f52.google.com with SMTP id e53so516583eek.39
 for <intel-gfx@lists.freedesktop.org>; Tue, 20 May 2014 05:07:49 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <537B43B2.50208@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Kumar, Shobhit" <shobhit.kumar@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, May 20, 2014 at 05:29:46PM +0530, Kumar, Shobhit wrote:
> On 4/25/2014 3:24 AM, Daniel Vetter wrote:
> >Looking at our current dsi driver I note that:
> >- We don't have any slave driver right now.
> >- There's zero support for the hardware state readout and cross check
> >   code.
> >- All the modeset state seems to be tracked in the intel_dsi structure
> >   instead of the pipe config.
> >
> >Given all that I can't properly audit the dsi ->mode_set callback. So
> >just do it as the first thing in the ->pre_pll_enable hook and hope
> >for the best.
> >
> 
> Though this is merged, given the uncertainty around this in absence of panel
> driver.
> 
> Verified-by: Shobhit Kumar <shobhit.kumar@intel.com>

Yeah we have a bit an ugly situation with dsi :( Thanks for checking.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch