From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/3] drm: add async version of hpd_irq_event Date: Wed, 21 May 2014 08:50:42 +0200 Message-ID: <20140521065042.GD24095@phenom.ffwll.local> References: <1400624735-4220-1-git-send-email-jbarnes@virtuousgeek.org> <1400624735-4220-2-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CA936E759 for ; Tue, 20 May 2014 23:50:47 -0700 (PDT) Received: by mail-ee0-f51.google.com with SMTP id e51so1190815eek.38 for ; Tue, 20 May 2014 23:50:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1400624735-4220-2-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 20, 2014 at 03:25:34PM -0700, Jesse Barnes wrote: > In some cases, the callers of this function may not need the return > value and delaying the uevent is ok. So add an async version of the > function for use in those cases. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/drm_probe_helper.c | 8 ++++++++ > include/drm/drm_crtc_helper.h | 2 ++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index 79f07f2..f3aee4a 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -446,3 +446,11 @@ bool drm_helper_hpd_irq_event(struct drm_device *dev) > return changed; > } > EXPORT_SYMBOL(drm_helper_hpd_irq_event); > + Kerneldoc is missing. -Daniel > +void drm_helper_hpd_irq_event_async(void *data, async_cookie_t cookie) > +{ > + struct drm_device *dev = data; > + > + drm_helper_hpd_irq_event(dev); > +} > +EXPORT_SYMBOL(drm_helper_hpd_irq_event_async); > diff --git a/include/drm/drm_crtc_helper.h b/include/drm/drm_crtc_helper.h > index a3d75fe..4f4ed9c 100644 > --- a/include/drm/drm_crtc_helper.h > +++ b/include/drm/drm_crtc_helper.h > @@ -33,6 +33,7 @@ > #ifndef __DRM_CRTC_HELPER_H__ > #define __DRM_CRTC_HELPER_H__ > > +#include > #include > #include > #include > @@ -172,6 +173,7 @@ extern int drm_helper_probe_single_connector_modes_nomerge(struct drm_connector > extern void drm_kms_helper_poll_init(struct drm_device *dev); > extern void drm_kms_helper_poll_fini(struct drm_device *dev); > extern bool drm_helper_hpd_irq_event(struct drm_device *dev); > +extern void drm_helper_hpd_irq_event_async(void *data, async_cookie_t cookie); > extern void drm_kms_helper_hotplug_event(struct drm_device *dev); > > extern void drm_kms_helper_poll_disable(struct drm_device *dev); > -- > 1.8.4.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch