From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915/vlv: assert and de-assert sideband reset at boot and resume v3 Date: Wed, 21 May 2014 11:06:45 -0700 Message-ID: <20140521110645.64bfbb90@jbarnes-desktop> References: <1400541397-22588-1-git-send-email-jbarnes@virtuousgeek.org> <1400609343-1076-1-git-send-email-jbarnes@virtuousgeek.org> <20140521175403.GS27580@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by gabe.freedesktop.org (Postfix) with SMTP id 9C3B06E0C6 for ; Wed, 21 May 2014 11:06:51 -0700 (PDT) In-Reply-To: <20140521175403.GS27580@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?UTF-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMSBNYXkgMjAxNCAyMDo1NDowMyArMDMwMApWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKCj4gT24gVHVlLCBNYXkgMjAsIDIwMTQg YXQgMTE6MDk6MDNBTSAtMDcwMCwgSmVzc2UgQmFybmVzIHdyb3RlOgo+ID4gVGhpcyBpcyBhIGJp dCBsaWtlIHRoZSBDTU4gcmVzZXQgZGUtYXNzZXJ0IHdlIGRvIGluIERQSU9fQ1RMLCBleGNlcHQK PiA+IHRoYXQgaXQgcmVzZXRzIHRoZSB3aG9sZSBjb21tb24gbGFuZSBzZWN0aW9uIG9mIHRoZSBQ SFkuICBUaGlzIGlzCj4gPiByZXF1aXJlZCBvbiBtYWNoaW5lcyB3aGVyZSB0aGUgQklPUyBkb2Vz bid0IGRvIHRoaXMgZm9yIHVzIG9uIGJvb3Qgb3IKPiA+IHJlc3VtZSB0byBwcm9wZXJseSByZS1j YWxpYnJhdGUgYW5kIGdldCB0aGUgUEhZIHJlYWR5IHRvIHRyYW5zbWl0IGRhdGEuCj4gPiAKPiA+ IFdpdGhvdXQgdGhpcyBwYXRjaCwgc3VjaCBtYWNoaW5lcyB3b24ndCByZXN1bWUgY29ycmVjdGx5 IG11Y2ggb2YgdGhlIHRpbWUsCj4gPiB3aXRoIHRoZSBzeW1wdG9tIGJlaW5nIGEgJ3BvcnQgcmVh ZHknIHRpbWVvdXQgYW5kL29yIGEgbGluayB0cmFpbmluZwo+ID4gZmFpbHVyZS4KPiA+IAo+ID4g djI6IGV4dHJhY3Qgc2ltcGxlciBzZXRfcG93ZXJfd2VsbCBmdW5jdGlvbiBmb3IgdXNlIGluIHJl c2V0X2RwaW8gKEltcmUpCj4gPiAgICAgbW92ZSB0byByZXNldF9kcGlvIChEYW5pZWwgJiBWaWxs ZSkKPiA+IHYzOiBkb24ndCByZXNldCBpZiBEUElPIHJlc2V0IGlzIGFscmVhZHkgZGUtYXNzZXJ0 ZWQgKEltcmUpCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEplc3NlIEJhcm5lcyA8amJhcm5lc0B2 aXJ0dW91c2dlZWsub3JnPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jIHwgMTkgKysrKysrKysrKysrKysrKysrKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rydi5oICAgICB8ICAzICsrLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3BtLmMgICAgICB8IDEzICsrKysrKysrKystLS0KPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDMx IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IGRmNThhZmMuLmJkYjQ2MjQgMTAwNjQ0Cj4gPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gQEAgLTE1MDksNiArMTUwOSwyNSBAQCBz dGF0aWMgdm9pZCBpbnRlbF9yZXNldF9kcGlvKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAg Cj4gPiAgCX0gZWxzZSB7Cj4gPiAgCQkvKgo+ID4gKwkJICogSWYgRFBJTyBoYXMgYWxyZWFkeSBi ZWVuIHJlc2V0LCBlLmcuIGJ5IEJJT1MsIGp1c3Qgc2tpcCBhbGwKPiA+ICsJCSAqIHRoaXMuCj4g PiArCQkgKi8KPiA+ICsJCWlmIChJOTE1X1JFQUQoRFBJT19DVEwpICYgRFBJT19DTU5SU1QpCj4g PiArCQkJcmV0dXJuOwo+ID4gKwo+ID4gKwkJLyoKPiA+ICsJCSAqIEZyb20gVkxWMkEwX0RQX2VE UF9IRE1JX0RQSU9fZHJpdmVyX3ZiaW9zX25vdGVzXzExLmRvY3g6Cj4gPiArCQkgKiBOZWVkIHRv IGFzc2VydCBhbmQgZGUtYXNzZXJ0IFBIWSBTQiByZXNldCBieSBnYXRpbmcgdGhlCj4gPiArCQkg KiBjb21tb24gbGFuZSBwb3dlciwgdGhlbiB1bi1nYXRpbmcgaXQuCj4gPiArCQkgKiBTaW1wbHkg dW5nYXRpbmcgaXNuJ3QgZW5vdWdoIHRvIHJlc2V0IHRoZSBQSFkgZW5vdWdoIHRvIGdldAo+ID4g KwkJICogcG9ydHMgYW5kIGxhbmVzIHJ1bm5pbmcuCj4gPiArCQkgKi8KPiA+ICsJCV9fdmx2X3Nl dF9wb3dlcl93ZWxsKGRldl9wcml2LCBQVU5JVF9QT1dFUl9XRUxMX0RQSU9fQ01OX0JDLAo+ID4g KwkJCQkgICAgIGZhbHNlKTsKPiA+ICsJCV9fdmx2X3NldF9wb3dlcl93ZWxsKGRldl9wcml2LCBQ VU5JVF9QT1dFUl9XRUxMX0RQSU9fQ01OX0JDLAo+ID4gKwkJCQkgICAgIHRydWUpOwo+IAo+IEht bS4gSSB3b25kZXIgaG93IHRoZSBwb3dlciB3ZWxsIGhhY2sgaW4gaW50ZWxfdW5jb3JlX3Nhbml0 aXplKCkgdGllcyBpbgo+IHdpdGggdGhpcy4gV2Ugc2hvdWxkIGRlZmluaXRlbHkgcmlwIHRoYXQg b3V0IHJlZ2FyZGxlc3MuCj4gCj4gQW5vdGhlciB0aGluZyBJJ20gd29kZXJpbmcgaXMgZGlkIHRo ZSBCSU9TL2h3IHJlYWxseSBwb3dlciBvbiB0aGUKPiBjb21tb24gbGFuZSwgb3IgZGlkIHdlIGRv IHRoYXQgb3V0c2VsdmVzPyBJZiB0aGUgbGF0dGVyLCB0aGVuIEkgd29uZGVyCj4gaWYgd2Ugc2lt cGx5IGRvIHRoYXQgdG9vIGVhcmx5LiBPciBtb3JlIHByZWNpc2VseSBkbyB3ZSBuZWVkIHRvIG1h a2UKPiBzdXJlIHRoZSBjcmkgY2xvY2sgYW5kL29yIHJlZmNsb2NrIGFyZSBlbmFibGVkIGJlZm9y ZSB3ZSBwb3dlciBvbiB0aGUKPiBjb21tb24gbGFuZT8KPiAKPiBBbmQgdGhpcmQgaXMgdGhhdCBk byB3ZSBuZWVkIHRvIGVuYWJsZSB0aGUgVFggd2VsbHMgYmVmb3JlIHRoZSBDTU4KPiB3ZWxsPyBD dXJyZW50bHkgd2UgZG8gdGhlIG9wcG9zaXRlIHdoaWNoIGNvdWxkIGFsc28gZXhwbGFpbiB3aHkg dGhpcwo+IENNTiB3ZWxsIHRvZ2dsZSBmaXhlcyB0aGluZ3MuCj4gCj4gQW5kIGZpbmFsbHkgd2Ug c2hvdWxkIG1ha2Ugc3VyZSB0aGUgY21ucmVzZXQgYXNzZXJ0L2RlYXNzZXJ0IGhhcHBlbnMKPiBj b3JlY2N0bHkgd3J0LiB0byB0aGUgcG93ZXIgd2VsbCB0cmFuc2l0aW9ucy4KPiAKPiAKPiBTbyBJ J2QgcmVhbGx5IGxpa2UgdG8gc2VlIHRoZSBmb2xsb3dpbmcgbWVhc3VyZXMgdGFrZW46Cj4gCj4g LSBraWxsIHBvd2VyIHdlbGwgaGFjayBmcm9tIGludGVsX3VuY29yZV9zYW5pdGl6ZSgpCj4gCj4g LSBtb3ZlIHRoZSBEUExMIHJlZ2lzdGVyIHNldHVwIGZyb20gaW50ZWxfcmVzZXRfZHBpbygpIGlu dG8KPiAgIHZsdl9zZXRfcG93ZXJfd2VsbCgpIGxpa2Ugc286Cj4gCj4gIHZsdl9zZXRfcG93ZXJf d2VsbCgpCj4gIHsKPiArCWlmIChwb3dlcl93ZWxsX2lkID09IFBVTklUX1BPV0VSX1dFTExfRFBJ T19DTU5fQkMgJiYgZW5hYmxlKSB7Cj4gKwkJSTkxNV9XUklURShEUExMLCAuLi4pOwo+ICsJCVBP U1RJTkdfUkVBRChEUExMKTsKPiArCQl1ZGVsYXkoMSk7IC8qID4xMG5zIGZvciBjbW5yZXNldCwg PjBucyBmb3Igc2lkZXJlc2V0ICovCj4gKwl9Cj4gCj4gCTxyZWFsbHkgZW5hYmxlIHRoZSBwb3dl ciB3ZWxsPgo+ICB9Cj4gCj4gLSByZW9yZGVyIHZsdl9wb3dlcl93ZWxsc1tdIHRvIGJyaW5nIHVw IFRYIHdlbGxzIGJlZm9yZSBDTU4uCj4gICBBbHRob3VnaCBtYXliZSB0aGUgRFBMTCBzdHVmZiBz aG91bGQgdGhlbiBiZSBkb25lIGFscmVhZHkgYmVmb3JlCj4gICB0aGUgVFggd2VsbHMgYXJlIGJy b3VnaHQgdXA/IEJ1dCBtYXliZSBub3QuCj4gCj4gLSBtb3ZlIHRoZSBjbW5yZXNldCBhc3NlcnQv ZGVhc3NlcnQgaW50byB0aGUgcG93ZXIgd2VsbCBjb2RlIGxpa2Ugc286Cj4gCj4gIHZsdl9zZXRf cG93ZXJfd2VsbCgpCj4gIHsKPiArCWlmIChwb3dlcl93ZWxsX2lkID09IFBVTklUX1BPV0VSX1dF TExfRFBJT19DTU5fQkMgJiYgIWVuYWJsZSkKPiArCQlhc3NlcnQgY21ucmVzZXQKPiAKPiAJPGRv IHN0dWZmPgo+IAo+ICsJaWYgKHBvd2VyX3dlbGxfaWQgPT0gUFVOSVRfUE9XRVJfV0VMTF9EUElP X0NNTl9CQyAmJiBlbmFibGUpIAo+ICsJCWRlYXNzZXJ0IGNtbnJlc2V0Cj4gIH0KPiAKPiAKPiBJ ZiB0aG9zZSBtZWFzdXJlcyBhcmVuJ3QgZW5vdWdoLCB0aGVuIEkgdGhpbmsgdGhpcyBwYXRjaCB3 b3VsZCBiZSBPSy4KPiBCdXQgcmlnaHQgbm93IEkgaGF2ZSB0aGlzIG5hZ2dpbmcgZmVlbGluZyB0 aGF0IHdlIG1heSBoYXZlIHNob3QKPiBvdXJzZWx2ZXMgaW4gdGhlIGZvb3QgYW5kIHdlJ3JlIGFi b3V0IHRvIHBpbGUgd29ya2Fyb3VuZHMgb24gdG9wIG9mIG91cgo+IG93biBidWcuCj4gCgpJIHdv cnJ5IGFib3V0IHRoaXMgdG9vLCBidXQgb24gdGhlIGZsaXAgc2lkZSB3ZSBvbmx5IGhhdmUgdGhl CmluY29tcGxldGUgZG9jIHRvIGxvb2sgYXQsIGFuZCB0aGVzZSBidWdzIGNhbiBiZSByZWFsbHkg aGFyZCB0byBmaW5kCmFuZCB0ZXN0IGZpeGVzIGZvciAodGhpcyByZXNldCBvbmUgaW4gcGFydGlj dWxhciBiaXQgb25seSBzb21lCm1hY2hpbmVzIG9uIG9ubHkgc29tZSBib290cyBmb3IgZXhhbXBs ZSkuCgpTbyBnb2luZyB3aXRoIHNvbWV0aGluZyB1bnRlc3RlZCBsaWtlIHRoZSBhYm92ZSBtYXkg bWFrZSBtb3JlIHNlbnNlLApidXQgbWF5IGFsc28gZ2l2ZSB1cyBhIGZhbHNlIHNlbnNlIG9mIHNl Y3VyaXR5IHdydCB0aGlzIGlzc3VlLgoKQ2FuIHlvdSBwaW5nIHRoZSBQSFkgZ3V5cyB3aXRoIHRo ZSBhYm92ZSBhbmQgc2VlIHdoYXQgdGhleSBoYXZlIHRvCnNheT8gIE1heWJlIGluIHRoZSBjb250 ZXh0IG9mIHRoZSB1cGRhdGVkIHByb2dyYW1taW5nIGRvYyBzdHVmZiBJIHNlbnQKb3V0PyAgSWRl YWxseSB3ZSBjb3VsZCBnZXQgZmlybSBhbnN3ZXJzLCB1cGRhdGUgdGhlIGRvY3MsIHRoZW4gdXBk YXRlCnRoZSBjb2RlLgoKSW4gdGhlIG1lYW50aW1lLCB1cHN0cmVhbSB3aWxsIGJlIGJyb2tlbiB3 aXRob3V0IGEgdGVzdGVkIGZpeCBvbiB0aGVzZQptYWNoaW5lcy4KClRoYW5rcywKLS0gCkplc3Nl IEJhcm5lcywgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK