public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Lee, Chon Ming" <chon.ming.lee@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Provide DPIO diagrams as docboox tables
Date: Wed, 21 May 2014 14:18:56 +0200	[thread overview]
Message-ID: <20140521121855.GC14357@phenom.ffwll.local> (raw)
In-Reply-To: <20140521105903.GC3860@clee30-mobl2.gar.corp.intel.com>

On Wed, May 21, 2014 at 06:59:03PM +0800, Lee, Chon Ming wrote:
> On 04/25 20:14, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > The ascii art version of the DPIO diagram gets mangled by docbook, so
> > we can't use it there. Insted provide another version built using
> > <table>.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> When generating drm.tmpl to html, it say no structured comments found for
> i915_reg.h
> 
> I am getting this error when displaying the link for i915_reg.h in HTML format: 
> Document generation inconsistency.
> 
> Not sure is some issue on my side because I have issue apply this patch series,
> so I apply manually.
> 
> Anyway, the table below is similar to your previous patch.  So,

Worked here, dunno what's broken on your side ... Note that some docbooks
moved around in 3.15-rc1 and the build system doesn't handle that. You
need to run a git clean -dfx in the Documentation directory to fix that.

> Reviewed-by: Chon Ming Lee <chon.ming.lee@intel.com>

Both patches merged, thanks.
-Daniel

> 
> > ---
> >  Documentation/DocBook/drm.tmpl | 86 ++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 86 insertions(+)
> > 
> > diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> > index e361ccd..bf11fe5 100644
> > --- a/Documentation/DocBook/drm.tmpl
> > +++ b/Documentation/DocBook/drm.tmpl
> > @@ -2945,6 +2945,92 @@ int num_ioctls;</synopsis>
> >        <sect2>
> >          <title>DPIO</title>
> >  !Pdrivers/gpu/drm/i915/i915_reg.h DPIO
> > +	<table id="dpiox2">
> > +	  <title>Dual channel PHY (VLV/CHV)</title>
> > +	  <tgroup cols="8">
> > +	    <colspec colname="c0" />
> > +	    <colspec colname="c1" />
> > +	    <colspec colname="c2" />
> > +	    <colspec colname="c3" />
> > +	    <colspec colname="c4" />
> > +	    <colspec colname="c5" />
> > +	    <colspec colname="c6" />
> > +	    <colspec colname="c7" />
> > +	    <spanspec spanname="ch0" namest="c0" nameend="c3" />
> > +	    <spanspec spanname="ch1" namest="c4" nameend="c7" />
> > +	    <spanspec spanname="ch0pcs01" namest="c0" nameend="c1" />
> > +	    <spanspec spanname="ch0pcs23" namest="c2" nameend="c3" />
> > +	    <spanspec spanname="ch1pcs01" namest="c4" nameend="c5" />
> > +	    <spanspec spanname="ch1pcs23" namest="c6" nameend="c7" />
> > +	    <thead>
> > +	      <row>
> > +		<entry spanname="ch0">CH0</entry>
> > +		<entry spanname="ch1">CH1</entry>
> > +	      </row>
> > +	    </thead>
> > +	    <tbody valign="top" align="center">
> > +	      <row>
> > +		<entry spanname="ch0">CMN/PLL/REF</entry>
> > +		<entry spanname="ch1">CMN/PLL/REF</entry>
> > +	      </row>
> > +	      <row>
> > +		<entry spanname="ch0pcs01">PCS01</entry>
> > +		<entry spanname="ch0pcs23">PCS23</entry>
> > +		<entry spanname="ch1pcs01">PCS01</entry>
> > +		<entry spanname="ch1pcs23">PCS23</entry>
> > +	      </row>
> > +	      <row>
> > +		<entry>TX0</entry>
> > +		<entry>TX1</entry>
> > +		<entry>TX2</entry>
> > +		<entry>TX3</entry>
> > +		<entry>TX0</entry>
> > +		<entry>TX1</entry>
> > +		<entry>TX2</entry>
> > +		<entry>TX3</entry>
> > +	      </row>
> > +	      <row>
> > +		<entry spanname="ch0">DDI0</entry>
> > +		<entry spanname="ch1">DDI1</entry>
> > +	      </row>
> > +	    </tbody>
> > +	  </tgroup>
> > +	</table>
> > +	<table id="dpiox1">
> > +	  <title>Single channel PHY (CHV)</title>
> > +	  <tgroup cols="4">
> > +	    <colspec colname="c0" />
> > +	    <colspec colname="c1" />
> > +	    <colspec colname="c2" />
> > +	    <colspec colname="c3" />
> > +	    <spanspec spanname="ch0" namest="c0" nameend="c3" />
> > +	    <spanspec spanname="ch0pcs01" namest="c0" nameend="c1" />
> > +	    <spanspec spanname="ch0pcs23" namest="c2" nameend="c3" />
> > +	    <thead>
> > +	      <row>
> > +		<entry spanname="ch0">CH0</entry>
> > +	      </row>
> > +	    </thead>
> > +	    <tbody valign="top" align="center">
> > +	      <row>
> > +		<entry spanname="ch0">CMN/PLL/REF</entry>
> > +	      </row>
> > +	      <row>
> > +		<entry spanname="ch0pcs01">PCS01</entry>
> > +		<entry spanname="ch0pcs23">PCS23</entry>
> > +	      </row>
> > +	      <row>
> > +		<entry>TX0</entry>
> > +		<entry>TX1</entry>
> > +		<entry>TX2</entry>
> > +		<entry>TX3</entry>
> > +	      </row>
> > +	      <row>
> > +		<entry spanname="ch0">DDI2</entry>
> > +	      </row>
> > +	    </tbody>
> > +	  </tgroup>
> > +	</table>
> >        </sect2>
> >      </sect1>
> >  
> > -- 
> > 1.8.3.2
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-05-21 12:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25 13:32 [PATCH] drm/i915: Add a brief description of the VLV display PHY internals ville.syrjala
2014-04-25 14:01 ` Daniel Vetter
2014-04-25 14:01   ` Daniel Vetter
2014-04-25 17:14   ` [PATCH 1/3] drm/i915: Drop /** */ comments from i915_reg.h ville.syrjala
2014-04-25 17:14     ` [PATCH v2 2/3] drm/i915: Add a brief description of the VLV display PHY internals ville.syrjala
2014-04-25 17:44       ` Daniel Vetter
2014-05-20 14:18         ` Daniel Vetter
2014-05-21  8:31       ` Lee, Chon Ming
2014-05-21  8:49         ` Ville Syrjälä
2014-05-21  9:58           ` Lee, Chon Ming
2014-05-21 10:31             ` Ville Syrjälä
2014-04-25 17:14     ` [PATCH 3/3] drm/i915: Provide DPIO diagrams as docboox tables ville.syrjala
2014-05-21 10:54       ` Damien Lespiau
2014-05-21 10:59       ` Lee, Chon Ming
2014-05-21 12:18         ` Daniel Vetter [this message]
2014-05-20 14:13     ` [PATCH 1/3] drm/i915: Drop /** */ comments from i915_reg.h Damien Lespiau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140521121855.GC14357@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chon.ming.lee@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox