From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/2] tests/drv_hangman: Convert test from
 shell script to c
Date: Thu, 22 May 2014 12:10:51 +0200
Message-ID: <20140522101051.GQ14357@phenom.ffwll.local>
References: <1400586933-6724-1-git-send-email-mika.kuoppala@intel.com>
 <92648605EABDA246B775AAB04C95A7A3012F0990@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42])
 by gabe.freedesktop.org (Postfix) with ESMTP id 5E9E86E3EC
 for <intel-gfx@lists.freedesktop.org>; Thu, 22 May 2014 03:10:55 -0700 (PDT)
Received: by mail-ee0-f42.google.com with SMTP id d49so2377059eek.15
 for <intel-gfx@lists.freedesktop.org>; Thu, 22 May 2014 03:10:54 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <92648605EABDA246B775AAB04C95A7A3012F0990@IRSMSX103.ger.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Mateo Lozano, Oscar" <oscar.mateo@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, May 21, 2014 at 03:40:15PM +0000, Mateo Lozano, Oscar wrote:
> > -----Original Message-----
> > From: Mika Kuoppala [mailto:mika.kuoppala@linux.intel.com]
> > Sent: Tuesday, May 20, 2014 12:56 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Mateo Lozano, Oscar
> > Subject: [PATCH 1/2] tests/drv_hangman: Convert test from shell script to c
> > 
> > Mixing script and standlone tests didn't mix well with the strict i915_ring_stop
> > flags handling. Also squash drv_missed_irq_hang to the new test.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78322
> > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> > ---
> >  tests/Makefile.sources    |    3 +-
> >  tests/drv_hangman         |   70 ---------
> >  tests/drv_hangman.c       |  357
> > +++++++++++++++++++++++++++++++++++++++++++++
> >  tests/drv_missed_irq_hang |   70 ---------
> 
> I am missing a tests/.gitignore entry
> Other than that: Reviewed-by: Oscar Mateo <oscar.mateo@intel.com>

The nop batch isn't good enough to reliably provoke a stall for the gpu.
Without that the missed irq test won't work. The script uses some pretty
expensive blitter workload (gem_exec_blt). Since patch 1 fixes a
regresssion I think we should just take out those subtests and keep the
missed_irq script for now so that we can push this series.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch