From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 2/3] drm/edid: Check for user aspect ratio input Date: Thu, 22 May 2014 13:42:25 +0200 Message-ID: <20140522114223.GB31378@ulmo> References: <1400757650-28636-1-git-send-email-vandana.kannan@intel.com> <1400757650-28636-2-git-send-email-vandana.kannan@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0123284585==" Return-path: In-Reply-To: <1400757650-28636-2-git-send-email-vandana.kannan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Vandana Kannan Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0123284585== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4bRzO86E/ozDv8r1" Content-Disposition: inline --4bRzO86E/ozDv8r1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 22, 2014 at 04:50:49PM +0530, Vandana Kannan wrote: > In case user has specified an input for aspect ratio through the property, > then the user space value for PAR would take preference over the value fr= om > CEA mode list. >=20 > Signed-off-by: Vandana Kannan > Cc: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/drm_edid.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 7a4fd2e..05db619 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3657,8 +3657,13 @@ drm_hdmi_avi_infoframe_from_display_mode(struct hd= mi_avi_infoframe *frame, > =20 > frame->picture_aspect =3D HDMI_PICTURE_ASPECT_NONE; > =20 > - /* Populate picture aspect ratio from CEA mode list */ > - if (frame->video_code > 0) > + /* Populate picture aspect ratio from either CEA mode list or > + * user input > + */ This comment is mangled, it should look like this: /* * Populate... */ And perhaps to clarify that user input takes precedence over CEA you could list it first in the comment, like so for example: /* * Populate picture aspect ratio from either user input (if specified) * or from the CEA mode. */ Also can you please resend patch 3/3 to dri-devel@lists.freedesktop.org as well so we can see how this is used in a driver? Thierry --4bRzO86E/ozDv8r1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTfeKfAAoJEN0jrNd/PrOhVgsP/0aDBx8bUAmofCQ5tGeon1zW xFZYWPLHxeeC8OT72g23AF2BMIVJTN6KjvnVaTwTgG4eHqMuB8VhR/HtNoc611Cd 6ow+CWtbElmET8EYaZoYSRjd6TcpbsDrNijmgPNzlmxBwhdfvZrxqzff7W3awe1l 7FBzMniWOjPrxgQMhaZG+anpJDg/EnB52xOHk/RWhgmMtNPfDJcZQVyDfw8T5K5A XEOZRYPnrCk0jWhxTtKZWMbSRo8XaWO1KNYq7v94vD3mVd03cMneh1sZGMd9KdqZ t9JwrHVv94cFaOdj1xc09WGUN6bxt4ZW7FgeE123kjCoRTcM5w/qr3kdCtdUYSC/ UMyVQ7zUXsYKoqHx6LxKAByMjV7iVmmAHGdaeIG6XEVuVX6fuU2OmlhEwtsaBTmG l4C4Xb1EcD8Vf/s7c0iskHrofOmGIWJQo2ai38JN6AahEIbgogsz6zlhpcUb9+g4 DzpFQLj6BY8UH/h/7vPxeWJ7W5oWl5zEcV6In30UP7s06AJW/OiFO9buO1BxcZAd Vszx4PVy6DXQ7ZhNjobMNRV5jPk5n33dncc7xnDWs8Db5vGXNY2zCd1BqgdkXTEg r12F+zeKTgCdLDxstfXm5h1UzL+ORiAiWASYNhFz/HhKU0/COvnBpsYNHyDfecEJ +dZa7E2CavD7gQLSoyOV =HtH+ -----END PGP SIGNATURE----- --4bRzO86E/ozDv8r1-- --===============0123284585== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0123284585==--