From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Kill intel_crtc->vbl_wait
Date: Thu, 22 May 2014 18:05:34 +0200
Message-ID: <20140522160534.GV14357@phenom.ffwll.local>
References: <1400773173-13813-1-git-send-email-ville.syrjala@linux.intel.com>
 <1400773173-13813-2-git-send-email-ville.syrjala@linux.intel.com>
 <20140522154903.GC12436@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20140522154903.GC12436@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, May 22, 2014 at 04:49:03PM +0100, Chris Wilson wrote:
> On Thu, May 22, 2014 at 06:39:33PM +0300, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > Share the waitqueue that drm_irq uses when performing the vblank evade
> > trick for atomic pipe updates.
> > =

> > Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_irq.c      | 25 ++++++-------------------
> >  drivers/gpu/drm/i915/intel_display.c |  2 --
> >  drivers/gpu/drm/i915/intel_drv.h     |  2 --
> >  drivers/gpu/drm/i915/intel_sprite.c  |  5 +++--
> >  4 files changed, 9 insertions(+), 25 deletions(-)
> > =

> > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i91=
5_irq.c
> > index 304f86a..5905a9d 100644
> > --- a/drivers/gpu/drm/i915/i915_irq.c
> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> > @@ -1724,19 +1724,6 @@ static void gen6_rps_irq_handler(struct drm_i915=
_private *dev_priv, u32 pm_iir)
> >  	}
> >  }
> >  =

> > -static bool intel_pipe_handle_vblank(struct drm_device *dev, enum pipe=
 pipe)
> > -{
> > -	struct intel_crtc *crtc;
> > -
> > -	if (!drm_handle_vblank(dev, pipe))
> > -		return false;
> > -
> > -	crtc =3D to_intel_crtc(intel_get_crtc_for_pipe(dev, pipe));
> > -	wake_up(&crtc->vbl_wait);
> > -
> > -	return true;
> > -}
> =

> Can we keep this bare wrapper? It is quite useful for hooking in vblank
> checks - i.e. saves me having to reinrtoduce it.

Just smash them into drm_handle_vblank?
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch