From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 1/2] drm: Add drm_crtc_vblank_waitqueue() Date: Thu, 22 May 2014 18:06:53 +0200 Message-ID: <20140522160653.GW14357@phenom.ffwll.local> References: <1400773173-13813-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1400773173-13813-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, May 22, 2014 at 06:39:32PM +0300, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > Add a small static inline helper to grab the vblank wait queue based on > the drm_crtc. Maybe add that this is useful for drivers to do internal vblank waits using wait event. > Suggested-by: Daniel Vetter > Signed-off-by: Ville Syrj=E4l=E4 > --- > include/drm/drmP.h | 4 ++++ > 1 file changed, 4 insertions(+) > = > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index 76ccaab..c294560 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -1378,6 +1378,10 @@ extern int drm_calc_vbltimestamp_from_scanoutpos(s= truct drm_device *dev, > extern void drm_calc_timestamping_constants(struct drm_crtc *crtc, > const struct drm_display_mode *mode); > = > +static inline wait_queue_head_t *drm_crtc_vblank_waitqueue(struct drm_cr= tc *crtc) Kerneldoc + pulling into the drm_irq docs missing. I guess we need to do an include directive which exactly names this function ... No other way with the drm header mess :( -Daniel > +{ > + return &crtc->dev->vblank[drm_crtc_index(crtc)].queue; > +} > = > /* Modesetting support */ > extern void drm_vblank_pre_modeset(struct drm_device *dev, int crtc); > -- = > 1.8.5.5 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch