Re: [Intel-gfx] [PATCH 1/2] drm: Add drm_crtc_vblank_waitqueue()

Daniel Vetter
2014-05-22T16:06:53Z

On Thu, May 22, 2014 at 06:39:32PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Add a small static inline helper to grab the vblank wait queue based on
> the drm_crtc.

Maybe add that this is useful for drivers to do internal vblank waits
using wait event.

> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> include/drm/drmP.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index 76ccaab..c294560 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -1378,6 +1378,10 @@ extern int drm_calc_vbltimestamp_from_scanoutpos(struct drm_device *dev,
> extern void drm_calc_timestamping_constants(struct drm_crtc *crtc,
> const struct drm_display_mode *mode);
>
> +static inline wait_queue_head_t *drm_crtc_vblank_waitqueue(struct drm_crtc *crtc)

Kerneldoc + pulling into the drm_irq docs missing. I guess we need to do
an include directive which exactly names this function ... No other way
with the drm header mess :(
-Daniel

> +{
> + return &crtc->dev->vblank[drm_crtc_index(crtc)].queue;
> +}
>
> /* Modesetting support */
> extern void drm_vblank_pre_modeset(struct drm_device *dev, int crtc);
> --
> 1.8.5.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch