From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] kms_cursor_crc: Move igt_pipe_crc_{new, free} to init
Date: Thu, 22 May 2014 22:23:49 +0200 [thread overview]
Message-ID: <20140522202349.GE14357@phenom.ffwll.local> (raw)
In-Reply-To: <20140522171258.GB27580@intel.com>
On Thu, May 22, 2014 at 08:12:58PM +0300, Ville Syrjälä wrote:
> On Thu, May 22, 2014 at 10:06:37AM -0700, Matt Roper wrote:
> > On Thu, May 22, 2014 at 08:01:09PM +0300, Ville Syrjälä wrote:
> > > On Thu, May 22, 2014 at 09:47:39AM -0700, Matt Roper wrote:
> > > > If a subtest fails, cleanup_crtc() never gets called. Currently that
> > > > also causes igt_pipe_crc_free() to never be called, leading all
> > > > subsequent subtests to also fail with -EBUSY at igt_pipe_crc_new().
> > > > Move the calls to igt_pipe_crc_{new,free} into igt_main so that
> > > > we don't need to worry about closing and reopening the CRC
> > > > filedescriptor for each subtest.
> > >
> > > IIRC we can't call them at init because when you call igt_pipe_crc_new()
> > > the pipe->port mapping has to be properly set up so that the auto crc
> > > source will know what to do.
> > >
> > > The subtest failure case is the reason why at the start of every subtest
> > > we call igt_pipe_crc_free() before calling igt_pipe_crc_new(). Are you
> > > saying that's not working as intended?
> >
> > Right, you're working on a fresh test_data structure for each call of
> > run_test(), so you've already lost the test_data->pipe_crc pointer that
> > you're trying to check for NULL there.
> >
> > I guess the right fix is to move the pipe_crc pointer up into data_t
> > rather than test_data_t?
>
> I guess just kill test_data_t and shovel everything into data_t. I don't
> remember why the test_data_t came to be there, but I don't think it
> serves any purpose anymore.
Also just run igts with piglit. That runs every subtest separately which
helps a lot for such issues. Running all the tests is kinda just the
quick&hacky versions if you're wreaking havoc with a single tests.
Otoh for that I just run one subtest through the cmdline switch. So not
sure how much we should bother here really ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-05-22 20:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 16:47 [PATCH i-g-t] kms_cursor_crc: Move igt_pipe_crc_{new, free} to init Matt Roper
2014-05-22 17:01 ` Ville Syrjälä
2014-05-22 17:06 ` Matt Roper
2014-05-22 17:12 ` Ville Syrjälä
2014-05-22 17:31 ` [PATCH i-g-t] kms_cursor_crc: Combine data_t and test_data_t Matt Roper
2014-05-22 20:23 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522202349.GE14357@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox