From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 4/6] drm/i915: Split the ringbuffers from
 the rings (3/3)
Date: Thu, 22 May 2014 23:44:34 +0200
Message-ID: <20140522214434.GK14357@phenom.ffwll.local>
References: <1400764418-30061-1-git-send-email-oscar.mateo@intel.com>
 <1400764418-30061-5-git-send-email-oscar.mateo@intel.com>
 <20140522213750.GI14357@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42])
 by gabe.freedesktop.org (Postfix) with ESMTP id 6F3006E4BB
 for <intel-gfx@lists.freedesktop.org>; Thu, 22 May 2014 14:44:39 -0700 (PDT)
Received: by mail-ee0-f42.google.com with SMTP id d49so2979719eek.15
 for <intel-gfx@lists.freedesktop.org>; Thu, 22 May 2014 14:44:38 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140522213750.GI14357@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: oscar.mateo@intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, May 22, 2014 at 11:37:50PM +0200, Daniel Vetter wrote:
> On Thu, May 22, 2014 at 02:13:36PM +0100, oscar.mateo@intel.com wrote:
> > From: Oscar Mateo <oscar.mateo@intel.com>
> > 
> > Manual cleanup after the previous Coccinelle script.
> > 
> > Yes, I could write another Coccinelle script to do this but I
> > don't want labor-replacing robots making an honest programmer's
> > work obsolete (also, I'm lazy).
> 
> Yeah, the tool has serious potential to make us unemployed. Unfortunately
> the documentation is really spotty, and figuring out some of the more
> obscure stuff takes a lot of fiddling :(
> 
> Aside: For reviewing such patches I prefer git diff --word-diff.

One more aside on top: One of the reasons I really like cocci is that it
also makes reviewing such large-scale refactorings easier. But I agree
that for this one here it would have been a bit more fuzz since matching
functions to add the struct intel_ringbuffer *ringbuf local variable is a
bit tricky to do.

Same goes for big sed patches - please add the precise sed filter to the
patch since reviewing that one is much less work than the resulting diff
;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch