Re: [PATCH 55/66] drm/i915: Add a debugfs file for the shared dpll state

Damien Lespiau
2014-05-20T10:33:47Z

On Thu, Apr 24, 2014 at 11:55:31PM +0200, Daniel Vetter wrote:
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

The list of CRTCs using those shared PLLs would also be useful in the
mix.

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

--
Damien

> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 1e83ae45041c..c99951fdc572 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2370,6 +2370,31 @@ static int i915_display_info(struct seq_file *m, void *unused)
> return 0;
> }
>
> +static int i915_shared_dplls_info(struct seq_file *m, void *unused)
> +{
> + struct drm_info_node *node = (struct drm_info_node *) m->private;
> + struct drm_device *dev = node->minor->dev;
> + struct drm_i915_private *dev_priv = dev->dev_private;
> + int i;
> +
> + drm_modeset_lock_all(dev);
> + for (i = 0; i < dev_priv->num_shared_dpll; i++) {
> + struct intel_shared_dpll *pll = &dev_priv->shared_dplls[i];
> +
> + seq_printf(m, "DPLL%i: %s, id: %i\n", i, pll->name, pll->id);
> + seq_printf(m, " refcount: %i, active: %i, on: %s\n", pll->refcount,
> + pll->active, yesno(pll->on));
> + seq_printf(m, " tracked hardware state:\n");
> + seq_printf(m, " dpll: 0x%08x\n", pll->hw_state.dpll);
> + seq_printf(m, " dpll_md: 0x%08x\n", pll->hw_state.dpll_md);
> + seq_printf(m, " fp0: 0x%08x\n", pll->hw_state.fp0);
> + seq_printf(m, " fp1: 0x%08x\n", pll->hw_state.fp1);
> + }
> + drm_modeset_unlock_all(dev);
> +
> + return 0;
> +}
> +
> struct pipe_crc_info {
> const char *name;
> struct drm_device *dev;
> @@ -3811,6 +3836,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
> {"i915_pc8_status", i915_pc8_status, 0},
> {"i915_power_domain_info", i915_power_domain_info, 0},
> {"i915_display_info", i915_display_info, 0},
> + {"i915_shared_dplls_info", i915_shared_dplls_info, 0},
> };
> #define I915_DEBUGFS_ENTRIES ARRAY_SIZE(i915_debugfs_list)
>
> --
> 1.8.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx