Re: [PATCH 23/66] drm/i915/dsi: Remove ->mode_set callback

Daniel Vetter
2014-05-20T12:07:50Z

On Tue, May 20, 2014 at 05:29:46PM +0530, Kumar, Shobhit wrote:
> On 4/25/2014 3:24 AM, Daniel Vetter wrote:
> >Looking at our current dsi driver I note that:
> >- We don't have any slave driver right now.
> >- There's zero support for the hardware state readout and cross check
> > code.
> >- All the modeset state seems to be tracked in the intel_dsi structure
> > instead of the pipe config.
> >
> >Given all that I can't properly audit the dsi ->mode_set callback. So
> >just do it as the first thing in the ->pre_pll_enable hook and hope
> >for the best.
> >
>
> Though this is merged, given the uncertainty around this in absence of panel
> driver.
>
> Verified-by: Shobhit Kumar <shobhit.kumar@intel.com>

Yeah we have a bit an ugly situation with dsi :( Thanks for checking.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch