Re: [PATCH 60/66] drm/i915: Document that the pll->mode_set hook is optional

Damien Lespiau
2014-05-20T11:08:10Z

On Thu, Apr 24, 2014 at 11:55:36PM +0200, Daniel Vetter wrote:
> The WRPLLs won't use them.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

/*
* Comments spawning multiple lines are formatted...
* ...this way
*/

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

--
Damien

> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index babeb7e92ee4..b01ee265310f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -198,6 +198,8 @@ struct intel_shared_dpll {
> /* should match the index in the dev_priv->shared_dplls array */
> enum intel_dpll_id id;
> struct intel_dpll_hw_state hw_state;
> + /* The mode_set hook is optional and should be used together with the
> + * intel_prepare_shared_dpll function. */
> void (*mode_set)(struct drm_i915_private *dev_priv,
> struct intel_shared_dpll *pll);
> void (*enable)(struct drm_i915_private *dev_priv,
> --
> 1.8.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx