From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/vlv: assert and de-assert sideband reset at boot and resume v3
Date: Fri, 23 May 2014 12:50:28 -0700 [thread overview]
Message-ID: <20140523125028.04f2de4d@jbarnes-desktop> (raw)
In-Reply-To: <20140521175403.GS27580@intel.com>
On Wed, 21 May 2014 20:54:03 +0300
Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> + if (power_well_id == PUNIT_POWER_WELL_DPIO_CMN_BC && enable)
> + deassert cmnreset
> }
>
>
> If those measures aren't enough, then I think this patch would be OK.
> But right now I have this nagging feeling that we may have shot
> ourselves in the foot and we're about to pile workarounds on top of our
> own bug.
I'll add these changes, with the additon that we need to do an actual
toggle at boot and init. Simply asserting in suspend or gate and then
de-asserting isn't enough to re-calibrate, since we tried that on the
Chromebooks across suspend/resume and it wasn't enough to get things
going again after the chip had lost power.
Across simple power well transitions it ought to be enough though, and
that's easy enough to verify in testing.
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-05-23 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 23:16 [PATCH] drm/i915/vlv: assert and de-assert sideband reset at boot and resume v2 Jesse Barnes
2014-05-20 18:09 ` [PATCH] drm/i915/vlv: assert and de-assert sideband reset at boot and resume v3 Jesse Barnes
2014-05-21 17:54 ` Ville Syrjälä
2014-05-21 18:06 ` Jesse Barnes
2014-05-21 18:11 ` Jesse Barnes
2014-05-21 18:43 ` Ville Syrjälä
2014-05-22 6:51 ` Imre Deak
2014-05-22 8:10 ` Ville Syrjälä
2014-05-22 15:43 ` Jesse Barnes
2014-05-23 19:50 ` Jesse Barnes [this message]
2014-05-20 18:10 ` [PATCH] drm/i915/vlv: assert and de-assert sideband reset at boot and resume v2 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523125028.04f2de4d@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox