Re: [v2] drm/i915: Add support for Generic MIPI panel driver

[Damien Lespiau <damien.lespiau@intel.com>]

On Fri, May 23, 2014 at 09:35:27PM +0530, Shobhit Kumar wrote:
> This driver makes use of the generic panel information from the VBT.
> Panel information is classified into two - panel configuration and panel
> power sequence which is unique to each panel. The generic driver uses the
> panel configuration and sequence parsed from VBT block #52 and #53
> 
> v2: Address review comments by Jani
>     - Move all of the things in driver c file from header
>     - Make all functions static
>     - Make use of video/mipi_display.c instead of redefining
>     - Null checks during sequence execution
> 
> v3: Address review comments by Damien
>     - Rename the panel driver file as intel_dsi_panel_vbt.c
>     - Fix style changes as suggested
>     - Correct comments for lp->hs and hs->lp count calculations
>     - General updating comments to have more clarity
>     - using max() instead of ternary operator
>     - Fix names (ui_num, ui_den) while using UI in calculations
>     - compute max of lp_to_hs switch and hs_to_lp switch while computing
>       hs_lp_switch_count
> 
> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>

Hopefully still works after all that :)

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

There's a small style issue I noticed with a last peek at the patch.
> +static bool generic_mode_fixup(struct intel_dsi_device *dsi,
> +		    const struct drm_display_mode *mode,
> +		    struct drm_display_mode *adjusted_mode) {
> +	return true;
> +}

-- 
Damien