From: Daniel Vetter <daniel@ffwll.ch>
To: "Kumar, Shobhit" <shobhit.kumar@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [v2] drm/i915: Add support for Generic MIPI panel driver
Date: Tue, 27 May 2014 13:37:23 +0200 [thread overview]
Message-ID: <20140527113723.GF14357@phenom.ffwll.local> (raw)
In-Reply-To: <53847553.2040703@intel.com>
On Tue, May 27, 2014 at 04:51:55PM +0530, Kumar, Shobhit wrote:
> On 5/27/2014 4:32 PM, Damien Lespiau wrote:
> >On Fri, May 23, 2014 at 09:35:27PM +0530, Shobhit Kumar wrote:
> >>This driver makes use of the generic panel information from the VBT.
> >>Panel information is classified into two - panel configuration and panel
> >>power sequence which is unique to each panel. The generic driver uses the
> >>panel configuration and sequence parsed from VBT block #52 and #53
> >>
> >>v2: Address review comments by Jani
> >> - Move all of the things in driver c file from header
> >> - Make all functions static
> >> - Make use of video/mipi_display.c instead of redefining
> >> - Null checks during sequence execution
> >>
> >>v3: Address review comments by Damien
> >> - Rename the panel driver file as intel_dsi_panel_vbt.c
> >> - Fix style changes as suggested
> >> - Correct comments for lp->hs and hs->lp count calculations
> >> - General updating comments to have more clarity
> >> - using max() instead of ternary operator
> >> - Fix names (ui_num, ui_den) while using UI in calculations
> >> - compute max of lp_to_hs switch and hs_to_lp switch while computing
> >> hs_lp_switch_count
> >>
> >>Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> >
> >Hopefully still works after all that :)
>
> It does, at least on AsusT100 :) Thanks for the review
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-27 11:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 5:48 [PATCH 0/4] Generic MIPI Panel driver Shobhit Kumar
2014-04-14 5:48 ` [PATCH 1/4] drm/i915: Correct MIPI operation mode as per expected values from VBT Shobhit Kumar
2014-05-15 15:03 ` Damien Lespiau
2014-04-14 5:48 ` [PATCH 2/4] drm/i915: MIPI init count programming as generic parameter Shobhit Kumar
2014-05-15 15:04 ` Damien Lespiau
2014-04-14 5:48 ` [PATCH 3/4] drm/i915: MIPI PPS delays added Shobhit Kumar
2014-05-15 15:06 ` Damien Lespiau
2014-05-15 20:44 ` Daniel Vetter
2014-04-14 5:48 ` [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver Shobhit Kumar
2014-05-15 16:48 ` Damien Lespiau
2014-05-16 9:23 ` Shobhit Kumar
2014-05-16 11:17 ` Damien Lespiau
2014-05-19 14:23 ` Damien Lespiau
2014-05-20 16:16 ` Shobhit Kumar
2014-05-20 20:55 ` Damien Lespiau
2014-05-22 7:45 ` Kumar, Shobhit
2014-05-23 16:05 ` [v2] " Shobhit Kumar
2014-05-27 11:02 ` Damien Lespiau
2014-05-27 11:21 ` Kumar, Shobhit
2014-05-27 11:37 ` Daniel Vetter [this message]
2014-05-27 11:39 ` Daniel Vetter
2014-05-27 11:42 ` Kumar, Shobhit
2014-05-27 11:51 ` Daniel Vetter
2014-05-27 12:26 ` Damien Lespiau
2014-05-27 13:53 ` [PATCH] drm/i915: Fix checkpatch errors Shobhit Kumar
2014-05-27 14:19 ` Damien Lespiau
2014-05-27 14:34 ` Kumar, Shobhit
2014-05-27 14:39 ` Damien Lespiau
2014-05-27 17:03 ` Daniel Vetter
2014-04-28 4:16 ` [PATCH 0/4] Generic MIPI Panel driver Kumar, Shobhit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527113723.GF14357@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=shobhit.kumar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox