From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 6/7] drm/i915/chv: Added CHV specific DDR fetch into init_clock_gating Date: Tue, 27 May 2014 14:59:38 +0300 Message-ID: <20140527115938.GL27580@intel.com> References: <1400859021-32202-1-git-send-email-deepak.s@linux.intel.com> <1400859021-32202-7-git-send-email-deepak.s@linux.intel.com> <877g58sh3o.fsf@gaia.fi.intel.com> <20140527114250.GI14357@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 94DCF6E3FD for ; Tue, 27 May 2014 05:00:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140527114250.GI14357@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 27, 2014 at 01:42:50PM +0200, Daniel Vetter wrote: > On Mon, May 26, 2014 at 06:19:07PM +0300, Mika Kuoppala wrote: > > deepak.s@linux.intel.com writes: > > = > > > From: Deepak S > > > > > > Signed-off-by: Deepak S > > > [vsyrjala: Fix merge fubmle where the code ended up in > > > g4x_disable_trickle_feed() instead of cherryview_init_clock_gating()] > > > Signed-off-by: Ville Syrj=E4l=E4 > > > Acked-by: Ben Widawsky > > > --- > > > drivers/gpu/drm/i915/intel_pm.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/i= ntel_pm.c > > > index 08dcdc5..0b73a6d 100644 > > > --- a/drivers/gpu/drm/i915/intel_pm.c > > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > > @@ -4026,7 +4026,18 @@ static void cherryview_enable_rps(struct drm_d= evice *dev) > > > GEN6_RP_UP_BUSY_AVG | > > > GEN6_RP_DOWN_IDLE_AVG); > > > = > > > + /* ToDo: Update the mem freq based on latest spec [CHV]*/ > > = > > Please do and consider fixing the vlv decoding. It seems to be off > > too. > = > Poke about this one here. Iirc the situation on vlv is simply terminal > confusion, and iirc the current code matches reality of shipping vbiosen, > but not any spec. Yeah changed back here: commit f6d519481b662d9fc52836e6e6107520f03e0122 Author: Deepak S Date: Thu Apr 3 21:01:28 2014 +0530 Revert "drm/i915/vlv: fixup DDR freq detection per Punit spec" = As per the inputs provided by hardware team we still use DDR Rates as 0,1=3D800, 2=3D1066, 3=3D1333. With this change, Turbo freqs used on current machines matches. I think what we need is a comment there which states why we're going against the spec, just to avoid future confusion and someone accidentally changing it back again. > I hope we're bettter for chv. One can dream. -- = Ville Syrj=E4l=E4 Intel OTC