From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH] drm/i915: Detect if MIPI panel based on VBT
 and initialize only if present
Date: Tue, 27 May 2014 13:27:27 +0100
Message-ID: <20140527122727.GE18389@strange.amr.corp.intel.com>
References: <1400861368-11691-1-git-send-email-shobhit.kumar@intel.com>
 <20140527113255.GB18389@strange.amr.corp.intel.com>
 <538480AF.2010702@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 749A76E67A
 for <intel-gfx@lists.freedesktop.org>; Tue, 27 May 2014 05:27:29 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <538480AF.2010702@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Kumar, Shobhit" <shobhit.kumar@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, Daniel Vetter <daniel.vetter@intel.com>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, May 27, 2014 at 05:40:23PM +0530, Kumar, Shobhit wrote:
> >>  	struct {
> >>+		u16 port;
> >
> >We store the port but never use it, is it needed?
> 
> Just wanted to store as we might want to use later while enabling.
> Shouldn't harm ? In fact we have a need to enable PORT C internally.

Sure, no harm there.

> >Also this is not what I have in my copy of the VBT documentation, I have
> >(in decimal) MIPI PORT_A = 11, .., PORT_D = 14
> 
> What I have say 21..24. Again this is the problem we need to fix.

Mind sending me your version?

-- 
Damien