From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [v3] drm/i915: Detect if MIPI panel based on VBT
 and initialize only if present
Date: Tue, 27 May 2014 17:31:42 +0300
Message-ID: <20140527143142.GN27580@intel.com>
References: <1401195382-21718-1-git-send-email-shobhit.kumar@intel.com>
 <1401199439-22703-1-git-send-email-shobhit.kumar@intel.com>
 <20140527141715.GA26962@strange.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id 482D36E6BC
 for <intel-gfx@lists.freedesktop.org>; Tue, 27 May 2014 07:31:46 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140527141715.GA26962@strange.amr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, May 27, 2014 at 03:17:15PM +0100, Damien Lespiau wrote:
> Sorry to be such a bore but:
> =

> On Tue, May 27, 2014 at 07:33:59PM +0530, Shobhit Kumar wrote:
> > --- a/drivers/gpu/drm/i915/intel_dsi.c
> > +++ b/drivers/gpu/drm/i915/intel_dsi.c
> > @@ -660,6 +660,10 @@ bool intel_dsi_init(struct drm_device *dev)
> >  =

> >  	DRM_DEBUG_KMS("\n");
> >  =

> > +	/* There is no detection method for MIPI so rely on VBT */
> > +	if (!dev_priv->vbt.has_mipi)
> > +		return false;
> > +
> =

> Huum, if we can intel_dsi_init() on VLV, but we don't have a MIPI panel,
> shouldn't return true here? ie. "intel_dsi_init() was successful, we
> just don't have a MIPI panel.

Why does it even have a return value? Either it added the
connector and encoder or it didn't.

-- =

Ville Syrj=E4l=E4
Intel OTC