From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix checkpatch errors Date: Tue, 27 May 2014 19:03:48 +0200 Message-ID: <20140527170348.GE14841@phenom.ffwll.local> References: <1401198826-13523-1-git-send-email-shobhit.kumar@intel.com> <20140527141956.GB26962@strange.amr.corp.intel.com> <5384A283.5010405@intel.com> <20140527143937.GD26962@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id EF5F66E776 for ; Tue, 27 May 2014 10:03:56 -0700 (PDT) Received: by mail-wi0-f174.google.com with SMTP id r20so2127740wiv.13 for ; Tue, 27 May 2014 10:03:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140527143937.GD26962@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, May 27, 2014 at 03:39:37PM +0100, Damien Lespiau wrote: > On Tue, May 27, 2014 at 08:04:43PM +0530, Kumar, Shobhit wrote: > > On 5/27/2014 7:49 PM, Damien Lespiau wrote: > > >On Tue, May 27, 2014 at 07:23:46PM +0530, Shobhit Kumar wrote: > > >>Fix warnings introduced by the following commit - > > >> > > >>commit 9c92da2c7c17eea79b6321b37592df0a002d24df > > >>Author: Shobhit Kumar > > >>Date: Fri May 23 21:35:27 2014 +0530 > > >> > > >> drm/i915: Add support for Generic MIPI panel driver > > >> > > >>Fixed all except the DRM logging which go beyond line 80 > > >> > > >>Signed-off-by: Shobhit Kumar > > > > > >To squash into previous commit? > > > > Can be done. I am not sure how this is handled for queued patches > > Daniel does a fair bit of this kind of editing when applying patches. I think I'll keep this one separate, as a cautionary tale ;-) Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch