From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [v3] drm/i915: Detect if MIPI panel based on VBT
 and initialize only if present
Date: Tue, 27 May 2014 19:05:15 +0200
Message-ID: <20140527170515.GF14841@phenom.ffwll.local>
References: <1401195382-21718-1-git-send-email-shobhit.kumar@intel.com>
 <1401199439-22703-1-git-send-email-shobhit.kumar@intel.com>
 <20140527141715.GA26962@strange.amr.corp.intel.com>
 <20140527143142.GN27580@intel.com>
 <20140527143544.GB27337@strange.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f170.google.com (mail-we0-f170.google.com
 [74.125.82.170])
 by gabe.freedesktop.org (Postfix) with ESMTP id B35B06E777
 for <intel-gfx@lists.freedesktop.org>; Tue, 27 May 2014 10:05:19 -0700 (PDT)
Received: by mail-we0-f170.google.com with SMTP id u57so10085077wes.29
 for <intel-gfx@lists.freedesktop.org>; Tue, 27 May 2014 10:05:18 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140527143544.GB27337@strange.amr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, May 27, 2014 at 03:35:44PM +0100, Damien Lespiau wrote:
> On Tue, May 27, 2014 at 05:31:42PM +0300, Ville Syrj=E4l=E4 wrote:
> > On Tue, May 27, 2014 at 03:17:15PM +0100, Damien Lespiau wrote:
> > > Sorry to be such a bore but:
> > > =

> > > On Tue, May 27, 2014 at 07:33:59PM +0530, Shobhit Kumar wrote:
> > > > --- a/drivers/gpu/drm/i915/intel_dsi.c
> > > > +++ b/drivers/gpu/drm/i915/intel_dsi.c
> > > > @@ -660,6 +660,10 @@ bool intel_dsi_init(struct drm_device *dev)
> > > >  =

> > > >  	DRM_DEBUG_KMS("\n");
> > > >  =

> > > > +	/* There is no detection method for MIPI so rely on VBT */
> > > > +	if (!dev_priv->vbt.has_mipi)
> > > > +		return false;
> > > > +
> > > =

> > > Huum, if we can intel_dsi_init() on VLV, but we don't have a MIPI pan=
el,
> > > shouldn't return true here? ie. "intel_dsi_init() was successful, we
> > > just don't have a MIPI panel.
> > =

> > Why does it even have a return value? Either it added the
> > connector and encoder or it didn't.
> =

> That's even better. I guess we can have a patch on top once this one has
> landed.

dp_init has this since edp init can fail and that decides what we will do
with it occasionally. But that's about it wrt reasons for a return value
for a encoder init function. Please remove.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch