From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: tell the user if both KMS and UMS are disabled
Date: Tue, 27 May 2014 19:19:23 +0200 [thread overview]
Message-ID: <20140527171923.GI14841@phenom.ffwll.local> (raw)
In-Reply-To: <1401207852-2115-1-git-send-email-jani.nikula@intel.com>
On Tue, May 27, 2014 at 07:24:12PM +0300, Jani Nikula wrote:
> If both KMS is disabled (by i915.modeset=0 or nomodeset parameters) and
> UMS is disabled (by CONFIG_DRM_I915_UMS=n, the default), the user might
> not be aware his setup is not supported. Inform the users (and, by
> extension, the poor i915 developers having to read their dmesgs in bug
> reports) why their graphics experience might be lacking.
>
> A similar message was added on the UMS path in
> commit e147accbd19f55489dabdcc4dc3551cc3e3f2553
> Author: Jani Nikula <jani.nikula@intel.com>
> Date: Thu Oct 10 15:25:37 2013 +0300
>
> drm/i915: tell the user KMS is required for gen6+
>
> but it won't be reached if CONFIG_DRM_I915_UMS=n since
> commit b30324adaf8d2e5950a602bde63030d15a61826f
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Wed Nov 13 22:11:25 2013 +0100
>
> drm/i915: Deprecated UMS support
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Hm, the idea is that this fails _very_ silently so that people only send
us regression reports if they actually notice something. Since if there
are still people out there which needs UMS, we can't yet rip it out.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 8949fd26b0ea..f0f690776d45 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1584,6 +1584,8 @@ static int __init i915_init(void)
> if (!(driver.driver_features & DRIVER_MODESET)) {
> driver.get_vblank_timestamp = NULL;
> #ifndef CONFIG_DRM_I915_UMS
> + DRM_INFO("Kernel modesetting (KMS) and userspace modesetting (UMS) disabled\n");
> + DRM_INFO("See CONFIG_DRM_I915_UMS, CONFIG_DRM_I915_KMS, nomodeset, and i915.modeset parameters\n");
> /* Silently fail loading to not upset userspace. */
> return 0;
> #endif
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-27 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 16:24 [PATCH] drm/i915: tell the user if both KMS and UMS are disabled Jani Nikula
2014-05-27 17:19 ` Daniel Vetter [this message]
2014-05-27 18:17 ` Jani Nikula
2014-06-02 13:58 ` [PATCH v2] " Jani Nikula
2014-06-02 15:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527171923.GI14841@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox