From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/6] drm/i915/vlv: re-order power wells so DPIO common comes after TX Date: Tue, 27 May 2014 22:21:27 +0200 Message-ID: <20140527202127.GN14841@phenom.ffwll.local> References: <1400876205-12997-1-git-send-email-jbarnes@virtuousgeek.org> <1400876205-12997-4-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 97F856E4CD for ; Tue, 27 May 2014 13:21:32 -0700 (PDT) Received: by mail-wi0-f169.google.com with SMTP id hi2so2327778wib.0 for ; Tue, 27 May 2014 13:21:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1400876205-12997-4-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, May 23, 2014 at 01:16:43PM -0700, Jesse Barnes wrote: > There may be a dependency here. > > Signed-off-by: Jesse Barnes Hm, this implicit ordering is a bit funky imo ... If this increase in complexity in furture platforms I think we should switch to epxlicit depencies and grab references in turn. Turtles all the way down and all. -Daniel > --- > drivers/gpu/drm/i915/intel_pm.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index e8f0c85..fb7e23e 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -6122,12 +6122,6 @@ static struct i915_power_well vlv_power_wells[] = { > .ops = &vlv_display_power_well_ops, > }, > { > - .name = "dpio-common", > - .domains = VLV_DPIO_CMN_BC_POWER_DOMAINS, > - .data = PUNIT_POWER_WELL_DPIO_CMN_BC, > - .ops = &vlv_dpio_power_well_ops, > - }, > - { > .name = "dpio-tx-b-01", > .domains = VLV_DPIO_TX_B_LANES_01_POWER_DOMAINS | > VLV_DPIO_TX_B_LANES_23_POWER_DOMAINS | > @@ -6163,6 +6157,12 @@ static struct i915_power_well vlv_power_wells[] = { > .ops = &vlv_dpio_power_well_ops, > .data = PUNIT_POWER_WELL_DPIO_TX_C_LANES_23, > }, > + { > + .name = "dpio-common", > + .domains = VLV_DPIO_CMN_BC_POWER_DOMAINS, > + .data = PUNIT_POWER_WELL_DPIO_CMN_BC, > + .ops = &vlv_dpio_power_well_ops, > + }, > }; > > #define set_power_wells(power_domains, __power_wells) ({ \ > -- > 1.8.4.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch