From: Ben Widawsky <ben@bwidawsk.net>
To: Ben Widawsky <benjamin.widawsky@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] [v3] drm/i915/bdw: Always issue a force restore
Date: Wed, 28 May 2014 22:54:21 -0700 [thread overview]
Message-ID: <20140529055420.GA15957@bwidawsk.net> (raw)
In-Reply-To: <1401318418-11860-1-git-send-email-benjamin.widawsky@intel.com>
On Wed, May 28, 2014 at 04:06:58PM -0700, Ben Widawsky wrote:
> The PDPs seem to get screwed up otherwise, specifically PDP0. I am not
> really clear why this is required, it just works with full PPGTT.
>
> v2: Only do it for gen8, to limit regression potential
>
> v3: Fix the bugzilla links
I should note there is a problem with this patch. Without full PPGTT, we
also do a restore inhibit on the default context, and therefore any test
which is running and not using contexts (like everything in IGT) is
programming restore inhibit as well as force restore, which as has been
pointed out in the semaphore series is weird at best.
All I know is the patch fixed at least a few of the bugs mentioned
below. I guess we'll figure out what to do when the QA results come in.
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-05-29 5:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <+1401318160-3199-1-git-send-email-benjamin.widawsky@intel.com>
2014-05-28 23:05 ` [PATCH] [v2] drm/i915/bdw: Always issue a force restore Ben Widawsky
2014-05-28 23:06 ` [PATCH] [v3] " Ben Widawsky
2014-05-29 5:54 ` Ben Widawsky [this message]
2014-05-29 6:32 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529055420.GA15957@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox