From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915/vlv: enable PPGTT Date: Thu, 29 May 2014 08:44:51 -0700 Message-ID: <20140529084451.7ebb8ec0@jbarnes-desktop> References: <1401314544-3247-1-git-send-email-jbarnes@virtuousgeek.org> <20140529153010.GA30692@bdvolkin-ubuntu-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 023D36E040 for ; Thu, 29 May 2014 08:44:34 -0700 (PDT) Received: by mail-pa0-f50.google.com with SMTP id fb1so566717pad.9 for ; Thu, 29 May 2014 08:44:34 -0700 (PDT) In-Reply-To: <20140529153010.GA30692@bdvolkin-ubuntu-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Volkin, Bradley D" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Thu, 29 May 2014 08:30:10 -0700 "Volkin, Bradley D" wrote: > On Wed, May 28, 2014 at 03:02:24PM -0700, Jesse Barnes wrote: > > Need testing and possibly disabling on earlier steppings, but looks ok > > here on my B3. > > > > Signed-off-by: Jesse Barnes > > --- > > drivers/gpu/drm/i915/i915_drv.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > > index ec5f6fb..4b0e58c 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.h > > +++ b/drivers/gpu/drm/i915/i915_drv.h > > @@ -1971,7 +1971,7 @@ struct drm_i915_cmd_table { > > > > #define HAS_HW_CONTEXTS(dev) (INTEL_INFO(dev)->gen >= 6) > > #define HAS_ALIASING_PPGTT(dev) (INTEL_INFO(dev)->gen >= 6 && !IS_VALLEYVIEW(dev)) > > -#define HAS_PPGTT(dev) (INTEL_INFO(dev)->gen >= 7 && !IS_VALLEYVIEW(dev) \ > > +#define HAS_PPGTT(dev) (INTEL_INFO(dev)->gen >= 7 \ > > && !IS_BROADWELL(dev)) > > Which branch is this against? In -nightly, these are implemented > differently, so I don't know if all comments will apply. But... > > Since IS_VALLEYVIEW() is also true for chv, should we make the condition > !IS_CHERRYVIEW() in this patch instead? Or do we intend to have PPGTT > enabled for chv? > > I think we need the corresponding change to HAS_ALIASING_PPGTT() in order > to actually enable PPGTT. Otherwise it looks like sanitize_enable_ppgtt() > will disable PPGTT. I knew this was too easy, maybe that's why it worked so well for Ville and I... unless I was somehow testing full PPGTT. I'll check it out. -- Jesse Barnes, Intel Open Source Technology Center