From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/vlv: enable PPGTT Date: Fri, 30 May 2014 00:12:04 +0300 Message-ID: <20140529211204.GU27580@intel.com> References: <1401314544-3247-1-git-send-email-jbarnes@virtuousgeek.org> <20140529153010.GA30692@bdvolkin-ubuntu-desktop> <20140529084451.7ebb8ec0@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 75E1E6E08A for ; Thu, 29 May 2014 14:12:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140529084451.7ebb8ec0@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Thu, May 29, 2014 at 08:44:51AM -0700, Jesse Barnes wrote: > On Thu, 29 May 2014 08:30:10 -0700 > "Volkin, Bradley D" wrote: > = > > On Wed, May 28, 2014 at 03:02:24PM -0700, Jesse Barnes wrote: > > > Need testing and possibly disabling on earlier steppings, but looks ok > > > here on my B3. > > > = > > > Signed-off-by: Jesse Barnes > > > --- > > > drivers/gpu/drm/i915/i915_drv.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > = > > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i= 915_drv.h > > > index ec5f6fb..4b0e58c 100644 > > > --- a/drivers/gpu/drm/i915/i915_drv.h > > > +++ b/drivers/gpu/drm/i915/i915_drv.h > > > @@ -1971,7 +1971,7 @@ struct drm_i915_cmd_table { > > > = > > > #define HAS_HW_CONTEXTS(dev) (INTEL_INFO(dev)->gen >=3D 6) > > > #define HAS_ALIASING_PPGTT(dev) (INTEL_INFO(dev)->gen >=3D 6 && !IS_= VALLEYVIEW(dev)) > > > -#define HAS_PPGTT(dev) (INTEL_INFO(dev)->gen >=3D 7 && !IS_VALLEYVI= EW(dev) \ > > > +#define HAS_PPGTT(dev) (INTEL_INFO(dev)->gen >=3D 7 \ > > > && !IS_BROADWELL(dev)) > > = > > Which branch is this against? In -nightly, these are implemented > > differently, so I don't know if all comments will apply. But... > > = > > Since IS_VALLEYVIEW() is also true for chv, should we make the condition > > !IS_CHERRYVIEW() in this patch instead? Or do we intend to have PPGTT > > enabled for chv? > > = > > I think we need the corresponding change to HAS_ALIASING_PPGTT() in ord= er > > to actually enable PPGTT. Otherwise it looks like sanitize_enable_ppgtt= () > > will disable PPGTT. > = > I knew this was too easy, maybe that's why it worked so well for Ville > and I... unless I was somehow testing full PPGTT. I'll check it out. #define HAS_HW_CONTEXTS(dev) (INTEL_INFO(dev)->gen >=3D 6) -#define HAS_ALIASING_PPGTT(dev) (INTEL_INFO(dev)->gen >=3D 6 && !IS= _VALLEYVIEW(dev)) -#define HAS_PPGTT(dev) (INTEL_INFO(dev)->gen >=3D 7 && !IS_VALLEYV= IEW(dev) \ +#define HAS_ALIASING_PPGTT(dev) (INTEL_INFO(dev)->gen >=3D 6) +#define HAS_PPGTT(dev) (INTEL_INFO(dev)->gen >=3D 7 \ && !IS_BROADWELL(dev)) is what I see in my branch, so I'm pretty sure I actually tested aliasing ppgtt. And IIRC I tried full ppgtt too (such as it was ~2 months ago). -- = Ville Syrj=E4l=E4 Intel OTC