From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, kristen@linux.intel.com
Subject: Re: [PATCH 2/4] drm/i915: leave rc6 enabled at suspend time
Date: Fri, 30 May 2014 11:20:12 -0700 [thread overview]
Message-ID: <20140530112012.005ecede@jbarnes-desktop> (raw)
In-Reply-To: <20140530154027.GA10916@nuc-i3427.alporthouse.com>
On Fri, 30 May 2014 16:40:27 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, May 30, 2014 at 08:32:20AM -0700, Jesse Barnes wrote:
> > But I can split that out if there's a reason to. Seems like we do a
> > bit too much teardown at suspend these days (like tearing down opregion
> > state), I'd like to trim it back if possible and share between runtime
> > and system suspend/freeze.
>
> I guess the answer is to move all the paranoid bits from suspend into
> hibernate-resume.
Well and probably move a bunch of stuff out of _freeze and into a
shared _suspend function for use at runtime suspend, suspend, and
hibernate.
Separate patches for all of that though so all the breakage is easily
bisected. :)
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-05-30 18:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 21:11 [PATCH 1/4] drm/i915: disable power wells on suspend Jesse Barnes
2014-05-29 21:11 ` [PATCH 2/4] drm/i915: leave rc6 enabled at suspend time Jesse Barnes
2014-05-30 12:54 ` Imre Deak
2014-05-30 15:32 ` Jesse Barnes
2014-05-30 15:40 ` Chris Wilson
2014-05-30 18:20 ` Jesse Barnes [this message]
2014-06-02 8:43 ` Daniel Vetter
2014-05-30 18:33 ` [PATCH] drm/i915: leave rc6 enabled at suspend time v2 Jesse Barnes
2014-06-04 19:33 ` [PATCH] drm/i915: leave rc6 enabled at suspend time v3 Jesse Barnes
2014-06-04 20:45 ` [PATCH] drm/i915: leave rc6 enabled at suspend time v4 Jesse Barnes
2014-06-05 9:21 ` Daniel Vetter
2014-06-05 15:50 ` Jesse Barnes
2014-06-10 13:42 ` Imre Deak
2014-06-10 13:57 ` Daniel Vetter
2014-06-10 14:41 ` Imre Deak
2014-06-10 15:26 ` Daniel Vetter
2014-06-11 22:21 ` Jesse Barnes
2014-06-11 22:24 ` Jesse Barnes
2014-06-12 15:08 ` Imre Deak
2014-05-30 19:00 ` [PATCH 2/4] drm/i915: leave rc6 enabled at suspend time Kristen Carlson Accardi
2014-05-29 21:11 ` [PATCH 3/4] drm/i915: send proper opregion notifications on suspend/resume Jesse Barnes
2014-05-29 21:48 ` [PATCH 3/5] ACPI: export target system state for use by drivers Jesse Barnes
2014-05-30 2:09 ` Rafael J. Wysocki
2014-05-29 21:48 ` [PATCH 4/5] drm/i915: send proper opregion notifications on suspend/resume Jesse Barnes
2014-05-30 13:47 ` [PATCH 3/4] " Imre Deak
2014-05-30 19:08 ` Kristen Carlson Accardi
2014-05-29 21:11 ` [PATCH 4/4] drm/i915: make sure PC8 is enabled on suspend and disabled on resume Jesse Barnes
2014-05-30 13:37 ` Imre Deak
2014-05-30 18:29 ` Jesse Barnes
2014-05-30 21:12 ` Rafael J. Wysocki
2014-05-30 21:05 ` Jesse Barnes
2014-05-30 18:32 ` [PATCH] drm/i915: make sure PC8 is enabled on suspend and disabled on resume v2 Jesse Barnes
2014-05-30 18:40 ` [PATCH] drm/i915: make sure PC8 is enabled on suspend and disabled on resume v3 Jesse Barnes
2014-05-30 18:48 ` [PATCH] drm/i915: make sure PC8 is enabled on suspend and disabled on resume v4 Jesse Barnes
2014-06-04 20:02 ` Imre Deak
2014-06-02 8:45 ` [PATCH 4/4] drm/i915: make sure PC8 is enabled on suspend and disabled on resume Daniel Vetter
2014-06-02 11:37 ` Imre Deak
2014-06-02 15:32 ` Daniel Vetter
2014-06-02 15:57 ` Imre Deak
2014-06-02 16:05 ` Daniel Vetter
2014-05-30 12:48 ` [PATCH 1/4] drm/i915: disable power wells on suspend Imre Deak
2014-05-30 18:59 ` Kristen Carlson Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530112012.005ecede@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kristen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox