Re: [PATCH 2/3] drm/i915: Change Mipi register definitions

[Damien Lespiau <damien.lespiau@intel.com>]

On Sat, May 31, 2014 at 01:32:42PM +0530, Shashank Sharma wrote:
> Re-define MIPI register definitions in such a way that most of
> the existing DSI code can be re-used for future platforms. Register
> definitions are re-written using MMIO offset variable, so that without
> changing the existing sequence, same code can be generically applied.
> 
> V4: Addressing review comments by Ville
> This patch removes all the un-necessary formatting changes.
> V5: Addressing review comments by Damien
> Changed input variable name from tc to pipe
> 
> Signed-off-by: Shashank Sharma <shashank.sharma@intel.com>

I'm sorry if we haven't been clear enough, but in a patch that changes
VLV_DISPLAY_BASE + 0xf00 to dev_priv->mipi_mmio_base + 0xf00, we can't
have:

> -#define MIPI_PORT_CTRL(pipe)		_PIPE(pipe, _MIPIA_PORT_CTRL, _MIPIB_PORT_CTRL)
> +#define MIPI_PORT_CTRL(pipe)			_PIPE(pipe, _MIPIA_PORT_CTRL, \
> +						_MIPIB_PORT_CTRL)

That's the un-necessary formatting changes that Ville was talking about,
and the "change only one thing per patch" I was talking about. In this
case the change is "make VLV_DISPLAY_BASE + 0xfoo" to
dev_priv->mipi_mmio_base + 0xf00", so the diff should only show that
kind of changes.

Please bear with me for this one, let's get it "correct" and I'm sure
the next ones will be easier.

-- 
Damien