From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 2/3] drm/i915: Change Mipi register
	definitions
Date: Sat, 31 May 2014 10:49:10 +0100
Message-ID: <20140531094910.GA22848@strange.config>
References: <20140530151048.GE15914@strange.amr.corp.intel.com>
 <1401523363-5566-1-git-send-email-shashank.sharma@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 725AF6E193
 for <intel-gfx@lists.freedesktop.org>; Sat, 31 May 2014 02:49:33 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1401523363-5566-1-git-send-email-shashank.sharma@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Shashank Sharma <shashank.sharma@intel.com>
Cc: intel-gfx@lists.freedesktop.org, daniel.vetter@intel.com
List-Id: intel-gfx@lists.freedesktop.org

On Sat, May 31, 2014 at 01:32:42PM +0530, Shashank Sharma wrote:
> Re-define MIPI register definitions in such a way that most of
> the existing DSI code can be re-used for future platforms. Register
> definitions are re-written using MMIO offset variable, so that without
> changing the existing sequence, same code can be generically applied.
> 
> V4: Addressing review comments by Ville
> This patch removes all the un-necessary formatting changes.
> V5: Addressing review comments by Damien
> Changed input variable name from tc to pipe
> 
> Signed-off-by: Shashank Sharma <shashank.sharma@intel.com>

I'm sorry if we haven't been clear enough, but in a patch that changes
VLV_DISPLAY_BASE + 0xf00 to dev_priv->mipi_mmio_base + 0xf00, we can't
have:

> -#define MIPI_PORT_CTRL(pipe)		_PIPE(pipe, _MIPIA_PORT_CTRL, _MIPIB_PORT_CTRL)
> +#define MIPI_PORT_CTRL(pipe)			_PIPE(pipe, _MIPIA_PORT_CTRL, \
> +						_MIPIB_PORT_CTRL)

That's the un-necessary formatting changes that Ville was talking about,
and the "change only one thing per patch" I was talking about. In this
case the change is "make VLV_DISPLAY_BASE + 0xfoo" to
dev_priv->mipi_mmio_base + 0xf00", so the diff should only show that
kind of changes.

Please bear with me for this one, let's get it "correct" and I'm sure
the next ones will be easier.

-- 
Damien