public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: enable PPGTT on VLV
@ 2014-05-29 21:33 Jesse Barnes
  2014-06-02  8:46 ` Daniel Vetter
  2014-06-02 11:09 ` Ville Syrjälä
  0 siblings, 2 replies; 5+ messages in thread
From: Jesse Barnes @ 2014-05-29 21:33 UTC (permalink / raw)
  To: intel-gfx

Working for real this time.  i915_ppgtt_info has all sorts of good stuff
in it and X is running nicely on top.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/i915_drv.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index bea9ab40..8631fb3 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1936,10 +1936,8 @@ struct drm_i915_cmd_table {
 #define I915_NEED_GFX_HWS(dev)	(INTEL_INFO(dev)->need_gfx_hws)
 
 #define HAS_HW_CONTEXTS(dev)	(INTEL_INFO(dev)->gen >= 6)
-#define HAS_ALIASING_PPGTT(dev)	(INTEL_INFO(dev)->gen >= 6 && \
-				 (!IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev)))
-#define HAS_PPGTT(dev)		(INTEL_INFO(dev)->gen >= 7 \
-				 && !IS_GEN8(dev))
+#define HAS_ALIASING_PPGTT(dev)	(INTEL_INFO(dev)->gen >= 6)
+#define HAS_PPGTT(dev)		(INTEL_INFO(dev)->gen >= 7 && !IS_GEN8(dev))
 #define USES_PPGTT(dev)		intel_enable_ppgtt(dev, false)
 #define USES_FULL_PPGTT(dev)	intel_enable_ppgtt(dev, true)
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: enable PPGTT on VLV
  2014-05-29 21:33 [PATCH] drm/i915: enable PPGTT on VLV Jesse Barnes
@ 2014-06-02  8:46 ` Daniel Vetter
  2014-06-02 11:09 ` Ville Syrjälä
  1 sibling, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2014-06-02  8:46 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: intel-gfx

On Thu, May 29, 2014 at 02:33:21PM -0700, Jesse Barnes wrote:
> Working for real this time.  i915_ppgtt_info has all sorts of good stuff
> in it and X is running nicely on top.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Maintainer-nitpick: Please don't forget the patch changelog ...
-Daniel

> ---
>  drivers/gpu/drm/i915/i915_drv.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bea9ab40..8631fb3 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1936,10 +1936,8 @@ struct drm_i915_cmd_table {
>  #define I915_NEED_GFX_HWS(dev)	(INTEL_INFO(dev)->need_gfx_hws)
>  
>  #define HAS_HW_CONTEXTS(dev)	(INTEL_INFO(dev)->gen >= 6)
> -#define HAS_ALIASING_PPGTT(dev)	(INTEL_INFO(dev)->gen >= 6 && \
> -				 (!IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev)))
> -#define HAS_PPGTT(dev)		(INTEL_INFO(dev)->gen >= 7 \
> -				 && !IS_GEN8(dev))
> +#define HAS_ALIASING_PPGTT(dev)	(INTEL_INFO(dev)->gen >= 6)
> +#define HAS_PPGTT(dev)		(INTEL_INFO(dev)->gen >= 7 && !IS_GEN8(dev))
>  #define USES_PPGTT(dev)		intel_enable_ppgtt(dev, false)
>  #define USES_FULL_PPGTT(dev)	intel_enable_ppgtt(dev, true)
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: enable PPGTT on VLV
  2014-05-29 21:33 [PATCH] drm/i915: enable PPGTT on VLV Jesse Barnes
  2014-06-02  8:46 ` Daniel Vetter
@ 2014-06-02 11:09 ` Ville Syrjälä
  2014-06-02 15:33   ` Daniel Vetter
  1 sibling, 1 reply; 5+ messages in thread
From: Ville Syrjälä @ 2014-06-02 11:09 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: intel-gfx

On Thu, May 29, 2014 at 02:33:21PM -0700, Jesse Barnes wrote:
> Working for real this time.  i915_ppgtt_info has all sorts of good stuff
> in it and X is running nicely on top.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

So it wasn't just my vlv where it appears to work. That's nice.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bea9ab40..8631fb3 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1936,10 +1936,8 @@ struct drm_i915_cmd_table {
>  #define I915_NEED_GFX_HWS(dev)	(INTEL_INFO(dev)->need_gfx_hws)
>  
>  #define HAS_HW_CONTEXTS(dev)	(INTEL_INFO(dev)->gen >= 6)
> -#define HAS_ALIASING_PPGTT(dev)	(INTEL_INFO(dev)->gen >= 6 && \
> -				 (!IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev)))
> -#define HAS_PPGTT(dev)		(INTEL_INFO(dev)->gen >= 7 \
> -				 && !IS_GEN8(dev))
> +#define HAS_ALIASING_PPGTT(dev)	(INTEL_INFO(dev)->gen >= 6)
> +#define HAS_PPGTT(dev)		(INTEL_INFO(dev)->gen >= 7 && !IS_GEN8(dev))
>  #define USES_PPGTT(dev)		intel_enable_ppgtt(dev, false)
>  #define USES_FULL_PPGTT(dev)	intel_enable_ppgtt(dev, true)
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: enable PPGTT on VLV
  2014-06-02 11:09 ` Ville Syrjälä
@ 2014-06-02 15:33   ` Daniel Vetter
  2014-06-06  6:22     ` Daniel Vetter
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2014-06-02 15:33 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

On Mon, Jun 02, 2014 at 02:09:06PM +0300, Ville Syrjälä wrote:
> On Thu, May 29, 2014 at 02:33:21PM -0700, Jesse Barnes wrote:
> > Working for real this time.  i915_ppgtt_info has all sorts of good stuff
> > in it and X is running nicely on top.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> So it wasn't just my vlv where it appears to work. That's nice.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: enable PPGTT on VLV
  2014-06-02 15:33   ` Daniel Vetter
@ 2014-06-06  6:22     ` Daniel Vetter
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2014-06-06  6:22 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

On Mon, Jun 02, 2014 at 05:33:26PM +0200, Daniel Vetter wrote:
> On Mon, Jun 02, 2014 at 02:09:06PM +0300, Ville Syrjälä wrote:
> > On Thu, May 29, 2014 at 02:33:21PM -0700, Jesse Barnes wrote:
> > > Working for real this time.  i915_ppgtt_info has all sorts of good stuff
> > > in it and X is running nicely on top.
> > > 
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > 
> > So it wasn't just my vlv where it appears to work. That's nice.
> > 
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Queued for -next, thanks for the patch.

https://bugs.freedesktop.org/show_bug.cgi?id=79670

There's more that are suspect.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-06  6:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-29 21:33 [PATCH] drm/i915: enable PPGTT on VLV Jesse Barnes
2014-06-02  8:46 ` Daniel Vetter
2014-06-02 11:09 ` Ville Syrjälä
2014-06-02 15:33   ` Daniel Vetter
2014-06-06  6:22     ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox