From: Damien Lespiau <damien.lespiau@intel.com>
To: "Sharma, Shashank" <shashank.sharma@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [PATCH 2/3] drm/i915: Change Mipi register definitions
Date: Mon, 2 Jun 2014 12:11:11 +0100 [thread overview]
Message-ID: <20140602111111.GA17233@strange.amr.corp.intel.com> (raw)
In-Reply-To: <FF3DDC77922A8A4BB08A3BC48A1EA8CB016BDC48@BGSMSX101.gar.corp.intel.com>
On Sun, Jun 01, 2014 at 06:41:54AM +0100, Sharma, Shashank wrote:
> Hi Damien,
> Please correct me if I am missing something, but the only reason we
> are seeing those extra formatting changes is, almost all of the old
> MIPI register definitions were beyond 80 char, and was checked in like
> that with warnings (How ?) So when I was checking for checkpatch
> errors, I saw that, and I tried to fix that in the previous patch.
You're absolutely correct.
However that 80 chars limit is a soft one and I think, in that case,
being able to review the patch wins. Would someone think it's a good
idea to have those definitions under 80 chars, one could always send a
patch *just* changing that. I wouln't bother.
--
Damien
next prev parent reply other threads:[~2014-06-02 11:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 15:24 [PATCH 0/2] Make DSI code re-usable Shashank Sharma
2014-05-19 15:24 ` [PATCH 1/2] drm/i915: Add MIPI mmio reg base Shashank Sharma
2014-05-19 15:45 ` Damien Lespiau
2014-05-19 15:55 ` Daniel Vetter
2014-05-19 15:57 ` Daniel Vetter
2014-05-19 15:24 ` [PATCH 2/2] drm/i915: Change Mipi register definitions Shashank Sharma
2014-05-19 16:10 ` Damien Lespiau
2014-05-21 15:26 ` Shashank Sharma
2014-05-21 15:35 ` Ville Syrjälä
2014-05-21 15:44 ` Sharma, Shashank
2014-05-21 15:49 ` Damien Lespiau
2014-05-22 11:32 ` Shashank Sharma
2014-05-30 8:05 ` Sharma, Shashank
2014-05-30 10:13 ` Damien Lespiau
2014-05-30 14:42 ` [PATCH 2/3] " Shashank Sharma
2014-05-30 14:42 ` [PATCH 3/3] drm/i915: Use transcoder as index to MIPI regs Shashank Sharma
2014-05-30 15:10 ` [PATCH 2/3] drm/i915: Change Mipi register definitions Damien Lespiau
2014-05-31 8:02 ` Shashank Sharma
2014-05-31 8:02 ` [PATCH 3/3] drm/i915: Use transcoder as index to MIPI regs Shashank Sharma
2014-05-31 9:49 ` [PATCH 2/3] drm/i915: Change Mipi register definitions Damien Lespiau
2014-06-01 5:41 ` Sharma, Shashank
2014-06-02 8:29 ` Daniel Vetter
2014-06-02 11:11 ` Damien Lespiau [this message]
2014-06-01 13:54 ` Shashank Sharma
2014-06-01 13:54 ` [PATCH 3/3] drm/i915: Use transcoder as index to MIPI regs Shashank Sharma
2014-06-02 11:23 ` [PATCH 2/3] drm/i915: Change Mipi register definitions Damien Lespiau
2014-06-02 12:37 ` shashank.sharma
2014-06-02 12:37 ` [PATCH 3/3] drm/i915: Use transcoder as index to MIPI regs shashank.sharma
2014-06-02 12:51 ` Damien Lespiau
2014-06-02 12:55 ` Sharma, Shashank
2014-06-02 13:26 ` Damien Lespiau
2014-06-02 15:08 ` Sharma, Shashank
2014-06-02 12:42 ` [PATCH 2/3] drm/i915: Change Mipi register definitions Damien Lespiau
2014-06-02 15:30 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602111111.GA17233@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shashank.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox