From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH] drm/i915: Make intel_dsi_init() return void Date: Tue, 3 Jun 2014 13:50:54 +0100 Message-ID: <20140603125054.GC17813@strange.amr.corp.intel.com> References: <1401276656-28377-1-git-send-email-damien.lespiau@intel.com> <87zjhufbb9.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B20C6E39C for ; Tue, 3 Jun 2014 05:51:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87zjhufbb9.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jun 03, 2014 at 03:05:14PM +0300, Jani Nikula wrote: > > - return false; > > + return; > > Okay this went in already, but I find return statements at the end of > void functions like that a bit silly... > > ...but hey, you can send a fix removing that! ;) Sigh, will do, thanks for pointed it out. -- Damien