From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Remove return;
 at the end of a function returning void
Date: Tue, 3 Jun 2014 16:36:11 +0200
Message-ID: <20140603143611.GG7416@phenom.ffwll.local>
References: <1401801676-8116-1-git-send-email-damien.lespiau@intel.com>
 <87fvjmf75m.fsf@intel.com>
 <20140603133727.GD17813@strange.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f169.google.com (mail-we0-f169.google.com
 [74.125.82.169])
 by gabe.freedesktop.org (Postfix) with ESMTP id E1ABB6E406
 for <intel-gfx@lists.freedesktop.org>; Tue,  3 Jun 2014 07:36:16 -0700 (PDT)
Received: by mail-we0-f169.google.com with SMTP id u56so7039529wes.0
 for <intel-gfx@lists.freedesktop.org>; Tue, 03 Jun 2014 07:36:16 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140603133727.GD17813@strange.amr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jun 03, 2014 at 02:37:27PM +0100, Damien Lespiau wrote:
> On Tue, Jun 03, 2014 at 04:35:01PM +0300, Jani Nikula wrote:
> > On Tue, 03 Jun 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> > > intel_dsi_init() lost its return value in:
> > >
> > >   Damien Lespiau <damien.lespiau@intel.com>
> > >   Date:   Wed May 28 12:30:56 2014 +0100
> > >
> > >      drm/i915: Make intel_dsi_init() return void
> > >
> > > However, I left a return; at the end of the function and, as Jani noticed, it
> > > looks silly.
> > 
> > Thanks. R-b and all that if Daniel needs it.
> 
> If it's not too late to rewrite history, please consider squashing it
> with:
> 	drm/i915: Make intel_dsi_init() return void

History is rectified.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch