From: Ben Widawsky <ben@bwidawsk.net>
To: Kenneth Graunke <kenneth@whitecape.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] rendercopy/gen8: Also emit 3DSTATE_WM_DEPTH_STENCIL.
Date: Tue, 3 Jun 2014 15:04:59 -0700 [thread overview]
Message-ID: <20140603220458.GA31603@bwidawsk.net> (raw)
In-Reply-To: <1401832350-10171-1-git-send-email-kenneth@whitecape.org>
On Tue, Jun 03, 2014 at 02:52:30PM -0700, Kenneth Graunke wrote:
> rendercopy was failing to emit 3DSTATE_WM_DEPTH_STENCIL, which is a new
> packet on Broadwell. Mesa emits this packet.
>
> This appears to fix various tests on a fresh boot, when Mesa has never
> run.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78890
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78891
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78935
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78936
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78937
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78938
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
> Cc: Ben Widawsky <ben@bwidawsk.net>
I sat with Ken all day today (after a few days of debugging myself) and
it does what it purport to do, and fixes a bunch of tests.
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
FWIW: I don't think we need to update the null state in the kernel. It's
actually kind of nice for finding userspace bugs.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-06-03 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 21:52 [PATCH] rendercopy/gen8: Also emit 3DSTATE_WM_DEPTH_STENCIL Kenneth Graunke
2014-06-03 22:04 ` Ben Widawsky [this message]
2014-06-04 7:27 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603220458.GA31603@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox