From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 2/4] drm/edid: Check for user aspect ratio input Date: Thu, 5 Jun 2014 08:33:32 +0200 Message-ID: <20140605063331.GA30845@ulmo> References: <537F267F.4070303@intel.com> <1401098862-30278-1-git-send-email-vandana.kannan@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0199720081==" Return-path: In-Reply-To: <1401098862-30278-1-git-send-email-vandana.kannan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vandana Kannan Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0199720081== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 26, 2014 at 03:37:42PM +0530, Vandana Kannan wrote: > In case user has specified an input for aspect ratio through the property, > then the user space value for PAR would take preference over the value fr= om > CEA mode list. >=20 > v2: Thierry's review comments. > - Modified the comment "Populate..." as per review comments >=20 > Signed-off-by: Vandana Kannan > Cc: Thierry Reding > Cc: Daniel Vetter >=20 > --- > drivers/gpu/drm/drm_edid.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 7a4fd2e..2628dd1 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3657,8 +3657,13 @@ drm_hdmi_avi_infoframe_from_display_mode(struct hd= mi_avi_infoframe *frame, > =20 > frame->picture_aspect =3D HDMI_PICTURE_ASPECT_NONE; > =20 > - /* Populate picture aspect ratio from CEA mode list */ > - if (frame->video_code > 0) > + /* Populate picture aspect ratio from either user input (if specified) > + * or from the CEA mode list > + */ Block comments should be of this form: /* * Populate ... * ... mode list. */ > + if (mode->picture_aspect_ratio =3D=3D HDMI_PICTURE_ASPECT_4_3 || > + mode->picture_aspect_ratio =3D=3D HDMI_PICTURE_ASPECT_16_9) > + frame->picture_aspect =3D mode->picture_aspect_ratio; > + else if (frame->video_code > 0) > frame->picture_aspect =3D drm_get_cea_aspect_ratio( > frame->video_code); With the above fixed, this is: Reviewed-by: Thierry Reding --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTkA87AAoJEN0jrNd/PrOhvF8QAMIQF89pbFYiFeT1wGzxLjNR +HTfsbkxtZ/IXcjjsYTHYun6xqDC/AQp+VRhiNrOIAK5YlBSCqHaQMYk/eShw3cn 1qXr54QmFdIQwQtgjNaS4z4VWaBMO+8UWAkyQJ9WlHjskzdl2Eb4s8raJe3USXTe 7ji40wpg/QEv5g2r7ZEo1k8ttyBcqCyH2cCnAGIYXTH1c6ge2gF0PL9tKZZeV9qR YHi2ll+1jUBjBwLe9uLhwN5ybB2e+UuabgkIDO3K+AbyukLBrPuD/Edj1TV+TgSj 2fQGW+oLbsctKCXyDdHgN4Fhy2RMsdvjTka+IAGzmz6f5xHYG8xWApwSIssUoOd8 fstMbg6rYarbkFDvGRb00BhspKcw8BPFBY+Pq7l5h6Cj9peNWSrgMtxFiaxKS3FS Lclo4yfRFO4k9JtCM6Zw7I5t62L3dmLDMw/w5xnwCRgpIus/C6xNFx3pBf/Y1lBm 9Ay3AKfAEqwXwnikBu/eF7XGUeDhY+0sCsa0E9htx41RMJ4FwKENdt6VdF8uzmZG RfNw/Ljepj1zRS7hYWiF+BPeaFwQ8Q6j/xPqJeLqZxyqJpYrt80G8mXzLx4Ub/BR oXKvI9NuXP0ugeaHOctdWttpBQl6a0FjAAsXeoOY9sAi8yTYneLYjb9bL6npim3F UCGR5TCfxVt9lZV0HzQR =O9bi -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7-- --===============0199720081== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0199720081==--