Re: [PATCH v3 2/4] drm/edid: Check for user aspect ratio input

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1395 bytes --]

On Thu, Jun 05, 2014 at 02:45:29PM +0530, Vandana Kannan wrote:
> In case user has specified an input for aspect ratio through the property,
> then the user space value for PAR would take preference over the value from
> CEA mode list.
> 
> v2: Thierry's review comments.
> 	- Modified the comment "Populate..." as per review comments
> 
> v3: Thierry's review comments.
> 	- Modified the comment to block comment format.
> 
> Signed-off-by: Vandana Kannan <vandana.kannan@intel.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> ---
>  drivers/gpu/drm/drm_edid.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 7a4fd2e..e76c58c 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -3657,8 +3657,14 @@ drm_hdmi_avi_infoframe_from_display_mode(struct hdmi_avi_infoframe *frame,
>  
>  	frame->picture_aspect = HDMI_PICTURE_ASPECT_NONE;
>  
> -	/* Populate picture aspect ratio from CEA mode list */
> -	if (frame->video_code > 0)
> +	/*
> +	 * Populate picture aspect ratio from either
> +	 * user input (if specified) or from the CEA mode list.
> +	 */

This still looks slightly odd. Why not use the full available width on
the first line of the comment?

But either way:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx