From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 2/4] drm/edid: Check for user aspect ratio input Date: Thu, 5 Jun 2014 11:25:33 +0200 Message-ID: <20140605092532.GA23099@ulmo> References: <20140605063331.GA30845@ulmo> <1401959729-14406-1-git-send-email-vandana.kannan@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1526872008==" Return-path: In-Reply-To: <1401959729-14406-1-git-send-email-vandana.kannan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Vandana Kannan Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1526872008== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 05, 2014 at 02:45:29PM +0530, Vandana Kannan wrote: > In case user has specified an input for aspect ratio through the property, > then the user space value for PAR would take preference over the value fr= om > CEA mode list. >=20 > v2: Thierry's review comments. > - Modified the comment "Populate..." as per review comments >=20 > v3: Thierry's review comments. > - Modified the comment to block comment format. >=20 > Signed-off-by: Vandana Kannan > Cc: Thierry Reding > --- > drivers/gpu/drm/drm_edid.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 7a4fd2e..e76c58c 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3657,8 +3657,14 @@ drm_hdmi_avi_infoframe_from_display_mode(struct hd= mi_avi_infoframe *frame, > =20 > frame->picture_aspect =3D HDMI_PICTURE_ASPECT_NONE; > =20 > - /* Populate picture aspect ratio from CEA mode list */ > - if (frame->video_code > 0) > + /* > + * Populate picture aspect ratio from either > + * user input (if specified) or from the CEA mode list. > + */ This still looks slightly odd. Why not use the full available width on the first line of the comment? But either way: Reviewed-by: Thierry Reding --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTkDeMAAoJEN0jrNd/PrOhOk8P/0Nrvv3ouvdq9PDbtkctrkK+ z51gBiIs17SqRJfiJsACtd3dHxFLqRHMT40Ma8WGp62V6B22oMZV6v4gIR9nsKvH fj0kKgqIMqVSgTXgS/KWsua2hWmrGZUtcfgX6rAoTQAmH8utI7xi+Yi1IidgFDPP gr1zdygG4jyWnQUeiAXPTXNdY4V+5III0dS4Q9ph4LtWXPi6S+Ua920cXvEyBXrU trl5ygGNxd+ox7wYTOztWKNZ2MrIE6GObO2yqox57RgFLgUxW1jSbRyWvAqxSIyk IFFomTuTIATJrdBb3Ve3p/Y5AyRxmi1qHI8ZfVexCy69jJMCX9qSL0C36X3nXnKB mIRr7e2ne6zfH7nztLBPaiTYFNwhtnmF+TnWrFkcMjYFBM486wpFUO0MRiMkb+Ug HqH+sXMeErXEDL17gCvCXiQCebgjir03Z12rOSHemSyr5xsDTRg8QEusw4lDwMyS u/2poxyHPMTmYr9uBI/cWxQmKFs6suC59yylM5eTewJucTfdbB+aIxockVZjPzoA DbV0voQwESyaV0OnVbQC8FUhrqczpy8zgnF93qIR+Rmf8jrCtfnxEBcKW5FvlJFL q793ivLDpuS2CLs/OEqDS8TMBai+SgsTdpH2x4si7t48HBO7+uctwCXqyT6DVpHT 7aGlJ9xY9YYMYFzo/2ed =r6Bv -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs-- --===============1526872008== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1526872008==--